From: Christian Couder <chriscool@tuxfamily.org>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org, chriscool@tuxfamily.org, gitster@pobox.com,
j6t@kdbg.org, jnareb@gmail.com
Subject: Re: [PATCH v8 4/7] bisect: introduce --no-checkout, --update-ref=<ref> support into porcelain.
Date: Sun, 31 Jul 2011 22:05:57 +0200 [thread overview]
Message-ID: <201107312205.57488.chriscool@tuxfamily.org> (raw)
In-Reply-To: <CAH3Anrp+Jynon0O8mQJnKvCNtp0v6oR9pLetmg0B6GnoP2QWMg@mail.gmail.com>
On Sunday 31 July 2011 21:48:40 you wrote:
> On Mon, Aug 1, 2011 at 4:35 AM, Christian Couder
>
> <christian.couder@gmail.com> wrote:
> > On Sun, Jul 31, 2011 at 1:55 PM, Jon Seymour <jon.seymour@gmail.com>
wrote:
> >> @@ -69,13 +71,18 @@ bisect_start() {
> >> orig_args=$(git rev-parse --sq-quote "$@")
> >> bad_seen=0
> >> eval=''
> >> + BISECT_UPDATE_REF=
> >> while [ $# -gt 0 ]; do
> >> arg="$1"
> >> case "$arg" in
> >> --)
> >> - shift
> >> - break
> >> - ;;
> >> + shift; break ;;
> >
> > Please don't change this. We try to avoid having many instructions on
> > the same line like this.
>
> Sure.
>
> FWIW: there are two places in git-am.sh and git-repack.sh that put shift on
> the same line as another statement,. Also this:
>
> case "$arg" in --) has_double_dash=1; break ;; esac
Yeah, we are not always consistent.
> However, 'fixing' those can be another change, assessed on its own merits.
Yeah, but I don't think it's worth it at least for the line above.
> >> + --no-checkout)
> >> + BISECT_UPDATE_REF=HEAD; shift ;;
> >
> > Perhaps:
> >
> > test -z "$BISECT_UPDATE_REF" && BISECT_UPDATE_REF=HEAD
> >
> > so that "--update-ref=someref --no-checkout" works the same as
> > "--no-checkout --update-ref=someref".
>
> Got the intent, thanks.
>
> How about BISECT_UPDATE_REF=${BISECT_UPDATE_REF:-HEAD}?
Yeah, nice.
Thanks,
Christian.
next prev parent reply other threads:[~2011-07-31 20:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 11:55 [PATCH v8 0/7] bisect: Add support for --no-checkout and --update-ref=<ref> options Jon Seymour
2011-07-31 11:55 ` [PATCH v8 1/7] bisect: move argument parsing before state modification Jon Seymour
2011-07-31 11:55 ` [PATCH v8 2/7] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-07-31 11:55 ` [PATCH v8 3/7] bisect: introduce support for --update-ref=<ref> option Jon Seymour
2011-07-31 11:55 ` [PATCH v8 4/7] bisect: introduce --no-checkout, --update-ref=<ref> support into porcelain Jon Seymour
2011-07-31 18:35 ` Christian Couder
2011-07-31 19:48 ` Jon Seymour
2011-07-31 20:05 ` Christian Couder [this message]
2011-07-31 19:21 ` Christian Couder
2011-07-31 19:40 ` Jon Seymour
2011-07-31 20:07 ` Christian Couder
2011-07-31 20:51 ` Christian Couder
2011-07-31 21:11 ` Jon Seymour
2011-07-31 11:55 ` [PATCH v8 5/7] bisect: add tests for the --no-checkout and --update-ref options Jon Seymour
2011-07-31 11:55 ` [PATCH v8 6/7] bisect: add documentation for --no-checkout and --update-ref=<ref> options Jon Seymour
2011-07-31 11:55 ` [PATCH v8 7/7] bisect: support --update-ref <ref> Jon Seymour
2011-07-31 13:26 ` [PATCH v8 0/7] bisect: Add support for --no-checkout and --update-ref=<ref> options Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107312205.57488.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).