From: Christian Couder <chriscool@tuxfamily.org>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git@vger.kernel.org, gitster@pobox.com, j6t@kdbg.org,
jnareb@gmail.com
Subject: Re: [PATCH v8 4/7] bisect: introduce --no-checkout, --update-ref=<ref> support into porcelain.
Date: Sun, 31 Jul 2011 22:07:58 +0200 [thread overview]
Message-ID: <201107312207.58818.chriscool@tuxfamily.org> (raw)
In-Reply-To: <CAH3AnrqasW=ZSix0YBgxHg8ca2X+YOvSWknbG2mjsy0NaqV+Mw@mail.gmail.com>
On Sunday 31 July 2011 21:40:35 Jon Seymour wrote:
> On Mon, Aug 1, 2011 at 5:21 AM, Christian Couder
>
> <christian.couder@gmail.com> wrote:
> > On Sun, Jul 31, 2011 at 1:55 PM, Jon Seymour <jon.seymour@gmail.com>
wrote:
> >> + if test -n "$BISECT_UPDATE_REF"; then
> >> + eval="$eval echo '$BISECT_UPDATE_REF' >
> >> '$GIT_DIR/BISECT_UPDATE_REF';" + fi
> >
> > I don't like this very much. In fact I realize that the eval thing we
> > use is buggy because the result of 'eval "eval"' will be the result of
> > the last command in "eval", so we won't detect if one of the first
> > command in "eval" failed.
>
> How about I fix the eval stitching so that it uses && rather than ; to
> connect each statement with a final true at the end so there is no
> dangling &&?
Yeah, please fix it in a separate bug fix patch.
> > So perhaps something like:
> >
> > eval "$eval" &&
> > + ( test -n "$BISECT_UPDATE_REF" || echo "$BISECT_UPDATE_REF" >
> > "$GIT_DIR/BISECT_UPDATE_REF" ) &&
> > echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit
>
> Probably this would be better :-)
>
> ( test -z "$BISECT_UPDATE_REF" || echo "$BISECT_UPDATE_REF" >
> "$GIT_DIR/BISECT_UPDATE_REF" ) &&
Yeah :-)
Thanks,
Christian.
PS: sorry I replied to you only previously
next prev parent reply other threads:[~2011-07-31 20:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 11:55 [PATCH v8 0/7] bisect: Add support for --no-checkout and --update-ref=<ref> options Jon Seymour
2011-07-31 11:55 ` [PATCH v8 1/7] bisect: move argument parsing before state modification Jon Seymour
2011-07-31 11:55 ` [PATCH v8 2/7] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-07-31 11:55 ` [PATCH v8 3/7] bisect: introduce support for --update-ref=<ref> option Jon Seymour
2011-07-31 11:55 ` [PATCH v8 4/7] bisect: introduce --no-checkout, --update-ref=<ref> support into porcelain Jon Seymour
2011-07-31 18:35 ` Christian Couder
2011-07-31 19:48 ` Jon Seymour
2011-07-31 20:05 ` Christian Couder
2011-07-31 19:21 ` Christian Couder
2011-07-31 19:40 ` Jon Seymour
2011-07-31 20:07 ` Christian Couder [this message]
2011-07-31 20:51 ` Christian Couder
2011-07-31 21:11 ` Jon Seymour
2011-07-31 11:55 ` [PATCH v8 5/7] bisect: add tests for the --no-checkout and --update-ref options Jon Seymour
2011-07-31 11:55 ` [PATCH v8 6/7] bisect: add documentation for --no-checkout and --update-ref=<ref> options Jon Seymour
2011-07-31 11:55 ` [PATCH v8 7/7] bisect: support --update-ref <ref> Jon Seymour
2011-07-31 13:26 ` [PATCH v8 0/7] bisect: Add support for --no-checkout and --update-ref=<ref> options Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107312207.58818.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).