From: Jeff King <peff@peff.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Jon Forrest <nobozo@gmail.com>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] For Real - Fixed pluralization in diff reports
Date: Mon, 1 Aug 2011 12:38:12 -0600 [thread overview]
Message-ID: <20110801183812.GA16438@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGdFq_j0Hr4LMaFC3irS8rhv2N0ePz_t8xpNTDCA-arC-E2UDA@mail.gmail.com>
On Mon, Aug 01, 2011 at 08:32:51PM +0200, Sverre Rabbelier wrote:
> On Mon, Aug 1, 2011 at 20:27, Jon Forrest <nobozo@gmail.com> wrote:
> > I entirely agree. My point is only that the various tests
> > that expect the current behavior will have to be changed
> > whether the implementation of correct plurals uses my
> > inferior method or the way more correct i18n method.
>
> Wouldn't it be a nice hack if we just solved problem through i18n
> then? Have all the plumbing see the current wording, but through i18n
> change it to something grammatically correct for the porcelain.
> Probably not possible, but a nice daydream :).
I thought there was still some question of whether this text was
something that should be script-parseable. If it is, then it shouldn't
be i18n'd at all, nor should we lightly change the format with
pluralization magic. And if it isn't, then we should definitely go the
full i18n route. So in either case, the original patch isn't
appropriate.
I don't have a strong opinion myself. I tend to lean towards i18n-ing
it, because any scripts should be using --numstat to parse, anyway.
OTOH, as Junio pointed out, we are matching the output of much older
tools, so pre-git scripts might be written to read the --stat format.
I've never seen such a script, and I have no idea how many there really
are.
-Peff
next prev parent reply other threads:[~2011-08-01 18:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 4:46 [PATCH] For Real - Fixed pluralization in diff reports Jon Forrest
2011-08-01 4:50 ` Nguyen Thai Ngoc Duy
2011-08-01 4:57 ` Jon Forrest
2011-08-01 5:21 ` Nguyen Thai Ngoc Duy
2011-08-01 9:58 ` Sverre Rabbelier
2011-08-01 14:32 ` Jon Forrest
2011-08-01 18:06 ` Jeff King
2011-08-01 18:27 ` Jon Forrest
2011-08-01 18:32 ` Sverre Rabbelier
2011-08-01 18:38 ` Jeff King [this message]
2011-08-03 13:38 ` Jakub Narebski
2011-08-03 16:52 ` Jon Forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801183812.GA16438@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nobozo@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).