From: Clemens Buchacher <drizzd@aon.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] notice error exit from pager
Date: Mon, 1 Aug 2011 22:35:44 +0200 [thread overview]
Message-ID: <20110801203544.GA22431@toss> (raw)
In-Reply-To: <7vd3goj38n.fsf@alter.siamese.dyndns.org>
On Mon, Aug 01, 2011 at 01:17:28PM -0700, Junio C Hamano wrote:
> Clemens Buchacher <drizzd@aon.at> writes:
>
> > Since there is no reliable way to handle error reporting in the
> > parent, produce the output in the child instead.
>
> Hmm, how does this interact with your earlier "error_routine: use parent's
> stderr if exec fails" patch?
The use case addressed in this patch (i.e., the pager) does not
strictly dependent on the previous patch. But Johannes noted that
in general, error output of the child could be redirected, hiding
the execve failure again. The error_routine patch avoids that by
writing to the parent's stderr stream.
Clemens
prev parent reply other threads:[~2011-08-01 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 21:04 [PATCH/RFC] notice error exit from pager Clemens Buchacher
2011-07-26 21:35 ` Linus Torvalds
2011-07-27 19:36 ` Johannes Sixt
2011-07-27 21:32 ` [PATCH] error_routine: use parent's stderr if exec fails Clemens Buchacher
2011-08-01 17:59 ` [PATCH] notice error exit from pager Clemens Buchacher
2011-08-01 20:17 ` Junio C Hamano
2011-08-01 20:35 ` Clemens Buchacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801203544.GA22431@toss \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).