From: Christian Couder <chriscool@tuxfamily.org>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git@vger.kernel.org, gitster@pobox.com, j6t@kdbg.org,
jnareb@gmail.com
Subject: Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain.
Date: Wed, 3 Aug 2011 07:27:03 +0200 [thread overview]
Message-ID: <201108030727.04246.chriscool@tuxfamily.org> (raw)
In-Reply-To: <CAH3AnrrkAeN3BgnnFBsbzh=37tC6f6aRACgk94wxW85qFQpfVw@mail.gmail.com>
On Tuesday 02 August 2011 16:41:13 Jon Seymour wrote:
> On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder
>
> <christian.couder@gmail.com> wrote:
> > On Tue, Aug 2, 2011 at 1:29 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
> >> @@ -34,6 +34,8 @@ require_work_tree
> >> _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
> >> _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
> >>
> >> +BISECT_MODE=$(test -f "$GIT_DIR/BISECT_MODE" && cat
> >> "$GIT_DIR/BISECT_MODE")
> >
> > Could you put this line just where it is needed, that is in
> > bisect_next() and bisect_reset()?
>
> Ultimately, it is also needed in paths that call bisect_state(), such
> as bisect_run() and bisect_skip() so I am not keen to do this.
>
> If I was to do this, I'd prefer to change uses of $BISECT_MODE with a
> call to a function bisect_mode() that does the same thing.
Yeah, I think it would be a good idea to have a bisect_mode() function.
I don't like very much to blindly call some code when we might not need it.
Thanks,
Christian.
next prev parent reply other threads:[~2011-08-03 5:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 11:28 [PATCH v13 0/8] bisect: Add support for --no-checkout option Jon Seymour
2011-08-02 11:28 ` [PATCH v13 1/8] bisect: move argument parsing before state modification Jon Seymour
2011-08-02 11:28 ` [PATCH v13 2/8] bisect: use && to connect statements that are deferred with eval Jon Seymour
2011-08-02 11:29 ` [PATCH v13 3/8] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-08-02 11:29 ` [PATCH v13 4/8] bisect: introduce support for --no-checkout option Jon Seymour
2011-08-02 12:16 ` Christian Couder
2011-08-02 14:42 ` Jon Seymour
2011-08-02 18:00 ` Junio C Hamano
2011-08-02 21:24 ` Jon Seymour
2011-08-02 22:05 ` Junio C Hamano
2011-08-02 22:19 ` Jon Seymour
2011-08-02 11:29 ` [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain Jon Seymour
2011-08-02 12:04 ` Christian Couder
2011-08-02 14:41 ` Jon Seymour
2011-08-03 5:27 ` Christian Couder [this message]
2011-08-03 12:46 ` Jon Seymour
2011-08-03 13:24 ` Jon Seymour
2011-08-03 14:09 ` Christian Couder
2011-08-03 15:13 ` Jon Seymour
2011-08-03 19:41 ` Christian Couder
2011-08-02 11:29 ` [PATCH v13 6/8] bisect: add tests for the --no-checkout option Jon Seymour
2011-08-02 11:29 ` [PATCH v13 7/8] bisect: add documentation for " Jon Seymour
2011-08-02 11:29 ` [PATCH v13 8/8] bisect: change bisect function to update BISECT_HEAD, rather than HEAD Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108030727.04246.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).