From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jon Seymour <jon.seymour@gmail.com>,
git@vger.kernel.org, chriscool@tuxfamily.org, j6t@kdbg.org,
jnareb@gmail.com
Subject: Re: [PATCH v14 5/8] bisect: introduce --no-checkout support into porcelain.
Date: Wed, 3 Aug 2011 20:57:19 +0200 [thread overview]
Message-ID: <20110803185719.GA4275@elie.Hillsp> (raw)
In-Reply-To: <7voc07ct9z.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Just a minor worry but I would not be surprised if somebody's "test"
> implementation barfs upon:
>
> test "--no-checkout" = "--no-checkout"
>
> mistaking the string with a dash at the beginning as an option unknown to
> it. That is why we often have "z$variable" in our comparison, like so:
>
> if test "z$BISECT_MODE" = "z--no-checkout"
Hmm.
$ git grep -e 'test "\$' | wc -l
712
$ git grep -e 'test ".\$' | wc -l
183
We are very inconsistent about such usage, generally, and of course
POSIX is very clear about the 'z' not being needed in a three-argument
"test" used for string comparison. Is there any platform that is
usable for git (e.g., that implements "$( ... )") and has that
problem?
next prev parent reply other threads:[~2011-08-03 18:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 22:15 [PATCH v14 0/8] bisect: Add support for --no-checkout option Jon Seymour
2011-08-02 22:15 ` [PATCH v14 1/8] bisect: move argument parsing before state modification Jon Seymour
2011-08-02 22:15 ` [PATCH v14 2/8] bisect: use && to connect statements that are deferred with eval Jon Seymour
2011-08-02 22:15 ` [PATCH v14 3/8] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-08-02 22:15 ` [PATCH v14 4/8] bisect: introduce support for --no-checkout option Jon Seymour
2011-08-02 22:15 ` [PATCH v14 5/8] bisect: introduce --no-checkout support into porcelain Jon Seymour
2011-08-02 23:01 ` Junio C Hamano
2011-08-02 23:16 ` Junio C Hamano
2011-08-03 5:28 ` Christian Couder
2011-08-03 13:16 ` Jon Seymour
2011-08-03 15:24 ` Jon Seymour
2011-08-03 17:01 ` Junio C Hamano
2011-08-03 18:57 ` Jonathan Nieder [this message]
2011-08-03 21:40 ` Jon Seymour
2011-08-03 21:45 ` Jonathan Nieder
2011-08-03 5:17 ` Christian Couder
2011-08-02 22:16 ` [PATCH v14 6/8] bisect: add tests for the --no-checkout option Jon Seymour
2011-08-02 22:16 ` [PATCH v14 7/8] bisect: add documentation for " Jon Seymour
2011-08-02 22:16 ` [PATCH v14 8/8] bisect: change bisect function to update BISECT_HEAD, rather than HEAD Jon Seymour
2011-08-03 4:43 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110803185719.GA4275@elie.Hillsp \
--to=jrnieder@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).