From: Christian Couder <chriscool@tuxfamily.org>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, j6t@kdbg.org, jnareb@gmail.com
Subject: Re: [PATCH v15 5/7] bisect: introduce --no-checkout support into porcelain.
Date: Wed, 3 Aug 2011 21:33:19 +0200 [thread overview]
Message-ID: <201108032133.19854.chriscool@tuxfamily.org> (raw)
In-Reply-To: <CAH3Anrrt-FPqWmDhv0ucQfGKmgVbGLFBE5Pf8ma1LWroydNWLQ@mail.gmail.com>
On Wednesday 03 August 2011 17:32:09 Jon Seymour wrote:
> On Thu, Aug 4, 2011 at 1:03 AM, Jon Seymour <jon.seymour@gmail.com> wrote:
> rm -f "$GIT_DIR/head-name" &&
>
> > -
> > - rm -f "$GIT_DIR/BISECT_START"
> > + rm -f "$GIT_DIR/BISECT_START" &&
> > + git update-ref -d BISECT_HEAD
> > }
>
> I'll reverse the order of the last two statements and restore the blank
> line...
Great!
It would be nice too if the "git update-ref" call that creates the ref in the
first place was after the creation of the $GIT_DIR/BISECT_START file.
This way we start by creating the $GIT_DIR/BISECT_START file and we finish by
deleting it.
That is change this:
...
+ test "$mode" != "--no-checkout" ||
+ git update-ref --no-deref BISECT_HEAD "$start_head" &&
echo "$start_head" >"$GIT_DIR/BISECT_START" &&
into something like this:
echo "$start_head" >"$GIT_DIR/BISECT_START" &&
+ {
+ test "$mode" != "--no-checkout" ||
+ git update-ref --no-deref BISECT_HEAD "$start_head"
+ } &&
...
Thanks,
Christian.
next prev parent reply other threads:[~2011-08-03 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 15:03 [PATCH v15 0/7] bisect: Add support for --no-checkout option Jon Seymour
2011-08-03 15:03 ` [PATCH v15 1/7] bisect: move argument parsing before state modification Jon Seymour
2011-08-03 15:03 ` [PATCH v15 2/7] bisect: use && to connect statements that are deferred with eval Jon Seymour
2011-08-03 15:03 ` [PATCH v15 3/7] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-08-03 15:03 ` [PATCH v15 4/7] bisect: introduce support for --no-checkout option Jon Seymour
2011-08-03 15:03 ` [PATCH v15 5/7] bisect: introduce --no-checkout support into porcelain Jon Seymour
2011-08-03 15:32 ` Jon Seymour
2011-08-03 19:33 ` Christian Couder [this message]
2011-08-03 15:03 ` [PATCH v15 6/7] bisect: add tests for the --no-checkout option Jon Seymour
2011-08-03 15:03 ` [PATCH v15 7/7] bisect: add documentation for " Jon Seymour
2011-08-03 20:59 ` Junio C Hamano
2011-08-03 21:37 ` Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108032133.19854.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).