From: Christian Couder <chriscool@tuxfamily.org>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git@vger.kernel.org, gitster@pobox.com, j6t@kdbg.org,
jnareb@gmail.com
Subject: Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain.
Date: Wed, 3 Aug 2011 21:41:10 +0200 [thread overview]
Message-ID: <201108032141.10618.chriscool@tuxfamily.org> (raw)
In-Reply-To: <CAH3Anro1Hs5VBT9901PoDdhGjtzTEZHWd9hgHvjfB_ivSErHMw@mail.gmail.com>
On Wednesday 03 August 2011 17:13:13 Jon Seymour wrote:
> On Thu, Aug 4, 2011 at 12:09 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
> > On Wed, Aug 3, 2011 at 3:24 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
> >> Mmmm.
> >>
> >> Actually, there is a neater way to do this.
> >>
> >> I'll such use the existence of BISECT_HEAD to inform the
> >> implementation of bisect_mode().
> >>
> >> This avoids the need for a separate .git/BISECT_MODE file.
> >
> > Yeah, but then you have to be careful of the fact that BISECT_HEAD
> > might have not been properly deleted or might have been created by the
> > user for other purposes.
>
> I have removed $GIT_DIR/BISECT_MODE in v15.
>
> If BISECT_HEAD was being used for other purposes, it is going to get
> deleted anyway, irrespective of whether we have a separate BISECT_MODE
> file, so I am not sure we need to consider that when deciding when we
> need a separate BISECT_MODE file.
Yeah, I was probably worrying too much.
> FWIW: bisect_mode() was only going to get called from one place so I
> just inlined the implementation in that place. (on the call to
> bisect--helper).
Ok.
Thanks,
Christian.
next prev parent reply other threads:[~2011-08-03 19:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 11:28 [PATCH v13 0/8] bisect: Add support for --no-checkout option Jon Seymour
2011-08-02 11:28 ` [PATCH v13 1/8] bisect: move argument parsing before state modification Jon Seymour
2011-08-02 11:28 ` [PATCH v13 2/8] bisect: use && to connect statements that are deferred with eval Jon Seymour
2011-08-02 11:29 ` [PATCH v13 3/8] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-08-02 11:29 ` [PATCH v13 4/8] bisect: introduce support for --no-checkout option Jon Seymour
2011-08-02 12:16 ` Christian Couder
2011-08-02 14:42 ` Jon Seymour
2011-08-02 18:00 ` Junio C Hamano
2011-08-02 21:24 ` Jon Seymour
2011-08-02 22:05 ` Junio C Hamano
2011-08-02 22:19 ` Jon Seymour
2011-08-02 11:29 ` [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain Jon Seymour
2011-08-02 12:04 ` Christian Couder
2011-08-02 14:41 ` Jon Seymour
2011-08-03 5:27 ` Christian Couder
2011-08-03 12:46 ` Jon Seymour
2011-08-03 13:24 ` Jon Seymour
2011-08-03 14:09 ` Christian Couder
2011-08-03 15:13 ` Jon Seymour
2011-08-03 19:41 ` Christian Couder [this message]
2011-08-02 11:29 ` [PATCH v13 6/8] bisect: add tests for the --no-checkout option Jon Seymour
2011-08-02 11:29 ` [PATCH v13 7/8] bisect: add documentation for " Jon Seymour
2011-08-02 11:29 ` [PATCH v13 8/8] bisect: change bisect function to update BISECT_HEAD, rather than HEAD Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108032141.10618.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).