From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] gitattributes: Clarify discussion of attribute macros
Date: Wed, 3 Aug 2011 16:40:33 -0600 [thread overview]
Message-ID: <20110803224032.GA31153@sigill.intra.peff.net> (raw)
In-Reply-To: <7v1ux2b2d8.fsf@alter.siamese.dyndns.org>
On Wed, Aug 03, 2011 at 02:40:19PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I don't know if that was intentional, or if the behavior is simply
> > accidental and the original code was simply never meant to have
> > "-binary" called at all.
>
> The latter. You were never expected to say -macro at all.
OK. Maybe we should flag an error, then? Or if not, then make the
documentation more clear that it's not allowed (or even say the current
behavior is reasonable, and document it).
-Peff
next prev parent reply other threads:[~2011-08-03 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 13:41 [PATCH 0/2] Clarify semantics of git attribute macros Michael Haggerty
2011-08-03 13:41 ` [PATCH 1/2] gitattributes: Clarify discussion of " Michael Haggerty
2011-08-03 19:46 ` Jeff King
2011-08-03 21:40 ` Junio C Hamano
2011-08-03 22:40 ` Jeff King [this message]
2011-08-03 13:41 ` [PATCH 2/2] gitattributes: Reword "attribute macro" to "macro attribute" Michael Haggerty
2011-08-03 21:34 ` [PATCH 0/2] Clarify semantics of git attribute macros Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110803224032.GA31153@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).