From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>,
git@vger.kernel.org, rene.scharfe@lsrfire.ath.cx
Subject: Re: git-archive's wrong documentation: really write pax rather than tar
Date: Wed, 3 Aug 2011 20:29:03 -0600 [thread overview]
Message-ID: <20110804022903.GA3388@sigill.intra.peff.net> (raw)
In-Reply-To: <7vwret6hgj.fsf@alter.siamese.dyndns.org>
On Wed, Aug 03, 2011 at 07:25:32PM -0700, Junio C Hamano wrote:
> > Actually, it is relevant for zip, too. The option should really be
> > called "--no-commit-id" or something similar. I don't think it's as big
> > a deal with zip (because there is no compatibility issue), but you may
> > want to omit the header for other reasons (e.g., because you know it
> > doesn't point to a commit that is public).
>
> Hmm, perhaps. It indeed is an implementation detail of the tar backend
> that the commit object name is stored in pax header, so --no-commit-id
> might make sense from "git" point of view, but from the point of view of
> OP that started this thread, he wouldn't care what that extra information
> is --- it can be a commit object name or it can be phase of the moon when
> the archive was made --- he just wants the extra header dropped.
>
> So I dunno.
If the intent of the option is "write plain-vanilla ustar" (I really
hope it doesn't need to be "plain-vanilla 4.3BSD tar"), then I think we
would do better to have a new --format type. Because from the OP's
perspective, it's not "drop this header that I don't like" but "make
something compatible with older versions of tar".
-Peff
next prev parent reply other threads:[~2011-08-04 2:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 22:17 git-archive's wrong documentation: really write pax rather than tar Hin-Tak Leung
2011-08-04 1:41 ` Jeff King
2011-08-04 1:56 ` Junio C Hamano
2011-08-04 2:00 ` Jeff King
2011-08-04 2:25 ` Junio C Hamano
2011-08-04 2:29 ` Jeff King [this message]
2011-08-04 17:39 ` René Scharfe
2011-08-04 2:13 ` Jeff King
2011-08-04 22:51 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2011-08-04 17:27 (unknown) Hin-Tak Leung
2011-08-04 17:54 ` git-archive's wrong documentation: really write pax rather than tar René Scharfe
2011-08-04 18:33 ` Hin-Tak Leung
2011-08-06 18:57 ` René Scharfe
2011-08-10 3:08 ` Hin-Tak Leung
2011-08-10 19:55 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804022903.GA3388@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=htl10@users.sourceforge.net \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).