From: Jeff King <peff@peff.net>
To: James Gregory <j.gregory@epigenesys.co.uk>
Cc: git@vger.kernel.org
Subject: Re: git-fast-export is returning streams with source code inside
Date: Fri, 5 Aug 2011 03:36:19 -0600 [thread overview]
Message-ID: <20110805093618.GA19062@sigill.intra.peff.net> (raw)
In-Reply-To: <CAFC9htyFKm7NCNFvrUkxXpmj1jwatWkxrnRSEdztY4Syo+EQ-g@mail.gmail.com>
On Fri, Aug 05, 2011 at 10:24:07AM +0100, James Gregory wrote:
> I've attached the valgrind.out file. If I'm reading the output
> properly, it does look like it is suffering from a memory leak.
It looks pretty innocuous:
> ==3267== Conditional jump or move depends on uninitialised value(s)
> ==3267== at 0x4E39510: inflateReset2 (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
> ==3267== by 0x4E39605: inflateInit2_ (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
> ==3267== by 0x4D5B02: ??? (in /usr/bin/git)
> ==3267== by 0x4BB059: ??? (in /usr/bin/git)
> ==3267== by 0x4BC464: ??? (in /usr/bin/git)
> ==3267== by 0x4BCA29: ??? (in /usr/bin/git)
> ==3267== by 0x4BCAFD: ??? (in /usr/bin/git)
> ==3267== by 0x4BD161: ??? (in /usr/bin/git)
> ==3267== by 0x49AEAC: ??? (in /usr/bin/git)
> ==3267== by 0x4B38AA: ??? (in /usr/bin/git)
> ==3267== by 0x4B422A: ??? (in /usr/bin/git)
> ==3267== by 0x4A9CD2: ??? (in /usr/bin/git)
This is a well-known false positive caused by zlib, and is nothing to
worry about.
> ==3267== LEAK SUMMARY:
> ==3267== definitely lost: 48,016 bytes in 3 blocks
> ==3267== indirectly lost: 30,226 bytes in 1,889 blocks
These are actual leaks, but minor.
> ==3267== possibly lost: 0 bytes in 0 blocks
> ==3267== still reachable: 2,743,134 bytes in 4,334 blocks
These are not really leaks, but rather things we don't bother cleaning
up since we're about to exit and let the OS reclaim memory (e.g., all of
the commit objects).
So yes, there's leaking, but it's not much. And more importantly, I was
looking not for leaks, but for memory access errors (of which there are
none, except for the zlib false positive).
So I'm not sure where to go from here. I can't reproduce the problem
locally. Is there anything else you can tell us about the problem? Does
it always happen on the same commit? If you export just that commit,
does the problem happen? Is there anything noteworthy in the contents of
that commit?
-Peff
next prev parent reply other threads:[~2011-08-05 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 11:57 git-fast-export is returning streams with source code inside James Gregory
2011-08-04 7:05 ` Jeff King
2011-08-04 9:08 ` James Gregory
2011-08-04 18:32 ` Jeff King
2011-08-05 9:24 ` James Gregory
2011-08-05 9:36 ` Jeff King [this message]
2011-08-05 9:54 ` James Gregory
2011-08-05 10:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805093618.GA19062@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j.gregory@epigenesys.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).