From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Daniel Mack <zonque@gmail.com>, David Aguilar <davvid@gmail.com>,
Greg KH <greg@kroah.com>,
git@vger.kernel.org
Subject: Re: Suppressing auto-cc for specific addresses
Date: Tue, 9 Aug 2011 01:01:41 -0600 [thread overview]
Message-ID: <20110809070141.GA13623@sigill.intra.peff.net> (raw)
In-Reply-To: <20110808210714.GA16512@elie.gateway.2wire.net>
On Mon, Aug 08, 2011 at 11:07:14PM +0200, Jonathan Nieder wrote:
> > I'm kind of confused why you would mark an address as "cc", but not cc
> > it. Wouldn't it make sense to call the header something else?
>
> Maybe the patch is a draft and he is seeking early feedback. The
> final version will be cc-ed to the indicated person later (and that's
> part of what it is time to get feedback on).
I suspect in that workflow, you would use --suppress-cc=all, and then
just address it to whomever you are getting feedback from.
> Or maybe the Cc: line is from the original patch and he is using git
> send-email to forward it without mangling.
In that case, shouldn't the cc either be respected (since the original
patch author wanted it so), or stripped (if the patch no longer has
anything to do with that cc).
Still, we are only guessing at possible workflows here. I don't have a
problem with the idea of per-address suppression; it makes git more
flexible and doesn't hurt people who don't need the flexibility.
I was more objecting to it as a solution to a workflow that is "we want
a unique tag in the commit, so we called it 'cc', but don't want people
to actually 'cc' it". That's just wrong and silly. But it turns out that
isn't happening here, anyway.
-Peff
next prev parent reply other threads:[~2011-08-09 7:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-07 20:20 Suppressing auto-cc for specific addresses Daniel Mack
2011-08-07 23:46 ` Greg KH
2011-08-08 7:24 ` Daniel Mack
[not found] ` <D95ADFD4-2504-4BE6-BCD4-7B916F6F2FEB@gmail.com>
2011-08-08 10:58 ` Daniel Mack
2011-08-08 20:44 ` Jeff King
2011-08-08 21:01 ` Daniel Mack
2011-08-08 21:11 ` Greg KH
2011-08-08 21:07 ` Jonathan Nieder
2011-08-09 7:01 ` Jeff King [this message]
2011-08-09 7:40 ` Daniel Mack
2011-08-08 21:17 ` Jonathan Nieder
2011-08-09 1:41 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809070141.GA13623@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
--cc=jrnieder@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).