git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	Daniel Barkalow <barkalow@iabervon.org>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH 4/5] sequencer: Expose code that handles files in .git/sequencer
Date: Thu, 11 Aug 2011 01:22:36 -0500	[thread overview]
Message-ID: <20110811062236.GA27394@elie.gateway.2wire.net> (raw)
In-Reply-To: <CALkWK0kxtyPABBUOrXtKDxPCBKt3CynoP4Fm8f_+C1ymkLTo-w@mail.gmail.com>

Hi Ram,

Ramkumar Ramachandra wrote:

> Are you certain about pick_revisions?  I've copied over the function
> here for your reference.  My issue is that it's too specific
> cherry-pick/ revert:

I'm a very pragmatic person: as long as the code and history are
readable and behave reasonably well, I'm happy.

So in this particular case, why not expose pick_revisions, with some
name like revert_or_cherry_pick?  It would be readable and behave
reasonably well. :)  A theoretical other caller could save a fork
by calling revert_or_cherry_pick instead of forking a subprocess to
do the same.

[...]
> 2. You mentioned multiple entry points earlier, and that's something
> I've been meaning to do: In the long run

Sure, and that still seems like a good idea in the long run.

But as long as we are not closing doors, ideas about the long run
should not get in the way of getting work done today.

Hoping that is clearer.
Jonathan

  reply	other threads:[~2011-08-11  6:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  9:55 [RFC PATCH 0/5] Some preliminary work based on sequencer-stable Ramkumar Ramachandra
2011-08-10  9:55 ` [PATCH 1/5] revert: Don't remove the sequencer state on error Ramkumar Ramachandra
2011-08-10  9:55 ` [PATCH 2/5] sequencer.h: Move data structures Ramkumar Ramachandra
2011-08-10  9:55 ` [PATCH 3/5] revert: Allow mixed pick and revert instructions Ramkumar Ramachandra
2011-08-10 15:15   ` Jonathan Nieder
2011-08-11  6:52     ` Ramkumar Ramachandra
2011-08-11  9:50     ` Ramkumar Ramachandra
2011-08-11 10:08       ` Jonathan Nieder
2011-08-10  9:55 ` [PATCH 4/5] sequencer: Expose code that handles files in .git/sequencer Ramkumar Ramachandra
2011-08-10 15:21   ` Jonathan Nieder
2011-08-10 15:34     ` Ramkumar Ramachandra
2011-08-10 15:53       ` Jonathan Nieder
2011-08-11  6:16         ` Ramkumar Ramachandra
2011-08-11  6:22           ` Jonathan Nieder [this message]
2011-08-11  6:27             ` Ramkumar Ramachandra
2011-08-10  9:55 ` [PATCH 5/5] sequencer: Remove sequencer state after final commit Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110811062236.GA27394@elie.gateway.2wire.net \
    --to=jrnieder@gmail.com \
    --cc=artagnon@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).