From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Christian Couder <chriscool@tuxfamily.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 3/5] revert: Allow mixed pick and revert instructions
Date: Thu, 11 Aug 2011 05:08:46 -0500 [thread overview]
Message-ID: <20110811100846.GA5012@elie.gateway.2wire.net> (raw)
In-Reply-To: <CALkWK0mMVgnngU5JB4O+7crCjGCdRnVrbm4jjsgkFFUMeBS9_A@mail.gmail.com>
Ramkumar Ramachandra wrote:
> Good point. I'm tempted to check (q - p < 40); is there a better way
> to do this by not hardcoding "40" perhaps?
Something like the following seems idiomatic.
if (q - p + 1 > sizeof(buf))
return error(...);
memcpy(buf, p, q - p);
buf[q - p] = '\0';
next prev parent reply other threads:[~2011-08-11 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 9:55 [RFC PATCH 0/5] Some preliminary work based on sequencer-stable Ramkumar Ramachandra
2011-08-10 9:55 ` [PATCH 1/5] revert: Don't remove the sequencer state on error Ramkumar Ramachandra
2011-08-10 9:55 ` [PATCH 2/5] sequencer.h: Move data structures Ramkumar Ramachandra
2011-08-10 9:55 ` [PATCH 3/5] revert: Allow mixed pick and revert instructions Ramkumar Ramachandra
2011-08-10 15:15 ` Jonathan Nieder
2011-08-11 6:52 ` Ramkumar Ramachandra
2011-08-11 9:50 ` Ramkumar Ramachandra
2011-08-11 10:08 ` Jonathan Nieder [this message]
2011-08-10 9:55 ` [PATCH 4/5] sequencer: Expose code that handles files in .git/sequencer Ramkumar Ramachandra
2011-08-10 15:21 ` Jonathan Nieder
2011-08-10 15:34 ` Ramkumar Ramachandra
2011-08-10 15:53 ` Jonathan Nieder
2011-08-11 6:16 ` Ramkumar Ramachandra
2011-08-11 6:22 ` Jonathan Nieder
2011-08-11 6:27 ` Ramkumar Ramachandra
2011-08-10 9:55 ` [PATCH 5/5] sequencer: Remove sequencer state after final commit Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811100846.GA5012@elie.gateway.2wire.net \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=barkalow@iabervon.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).