From: Jeff King <peff@peff.net>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Marat Radchenko <marat@slonopotamus.org>
Subject: Re: [PATCH v2] xdiff/xprepare: improve O(n*m) performance in xdl_cleanup_records()
Date: Tue, 16 Aug 2011 22:21:47 -0700 [thread overview]
Message-ID: <20110817052147.GA11253@sigill.intra.peff.net> (raw)
In-Reply-To: <1313546037-4104-1-git-send-email-rctay89@gmail.com>
On Wed, Aug 17, 2011 at 09:53:57AM +0800, Tay Ray Chuan wrote:
> > Could we have some benchmarks to let the readers get a feel of how much
> > improvement this patch brings in?
>
> On my msysgit machine with Marat's problematic repo
> (git://slonopotamus.org/git-diff):
>
> rctay@TEST-123 /tmp/slono
> $ time git show >/dev/null
>
> real 0m8.538s
> user 0m0.000s
> sys 0m0.031s
>
> rctay@TEST-123 /tmp/slono
> $ time /git/git show >/dev/null
>
> real 0m0.672s
> user 0m0.031s
> sys 0m0.031s
Wait, what? It was using 0 seconds of user time before, but still taking
8.5 seconds? What was it doing? Did you actually warm up your disk cache
before taking these measurements?
-Peff
next prev parent reply other threads:[~2011-08-17 5:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 7:51 git diff is slow (--patience is fast) Marat Radchenko
2011-08-09 10:49 ` Tay Ray Chuan
2011-08-09 11:39 ` Marat Radchenko
2011-08-16 3:01 ` Tay Ray Chuan
2011-08-16 3:11 ` [PATCH] xdiff/xprepare: improve O(n*m) performance in xdl_cleanup_records() Tay Ray Chuan
2011-08-16 3:37 ` Tay Ray Chuan
2011-08-16 17:39 ` Junio C Hamano
2011-08-17 1:53 ` [PATCH v2] " Tay Ray Chuan
2011-08-17 5:21 ` Jeff King [this message]
2011-08-17 15:55 ` Tay Ray Chuan
2011-08-18 22:44 ` Jeff King
2011-08-19 17:12 ` Tay Ray Chuan
2011-08-21 9:24 ` Johannes Sixt
2011-08-24 6:29 ` Marat Radchenko
2011-08-24 6:32 ` Marat Radchenko
2011-08-27 8:50 ` Marat Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817052147.GA11253@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marat@slonopotamus.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).