From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Elijah Newren <newren@gmail.com>,
Owen Stephens <git@owenstephens.co.uk>,
git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: Malformed branch name in fast-export when specifying non-HEAD/branch revision
Date: Wed, 17 Aug 2011 16:19:22 -0700 [thread overview]
Message-ID: <20110817231922.GA28966@sigill.intra.peff.net> (raw)
In-Reply-To: <7vliurd62x.fsf@alter.siamese.dyndns.org>
On Wed, Aug 17, 2011 at 03:30:14PM -0700, Junio C Hamano wrote:
> You can think of "fast-export" an off-line "push" command [*1*]; instead
> of giving a random commit object, e.g. "git fast-export HEAD~1", that can
> not be used as a ref, you can use the refspec notation to tell where the
> result should go, e.g. "git fast-export HEAD~1:refs/heads/a-bit-older",
> from the command line of fast-export.
>
> I suspect that also may clarify what Sverre was trying to do in his recent
> series. The root cause of both this and the issue Sverre wanted to fix is
> the design mistake of fast-export that tries to reuse the notation of
> object range specification for a different purpose of telling which "ref"
> to update, I think.
Yes, this was the conclusion I came to when I looked at this a month or
so ago. You really need to give fast-export a mapping of objects to
refnames, and it should output ref names _only_ for the mapping. That
would handle this "not a ref" case, but would also let you push
"refs/heads/foo" when it is equivalent to "refs/heads/master", without
fast-export mentioning "refs/heads/master" at all.
-Peff
next prev parent reply other threads:[~2011-08-17 23:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAORuUR1viqG27+dYOFS_5SLxFOE2wHJqAQ3i3RByg_fbWACh-Q@mail.gmail.com>
2011-08-17 16:21 ` Malformed branch name in fast-export when specifying non-HEAD/branch revision Owen Stephens
2011-08-17 19:36 ` Elijah Newren
2011-08-17 22:30 ` Junio C Hamano
2011-08-17 23:19 ` Jeff King [this message]
2011-08-21 22:29 ` Sverre Rabbelier
2011-08-22 16:19 ` Jeff King
2011-08-22 16:54 ` Sverre Rabbelier
2011-08-22 17:57 ` Jeff King
2011-08-22 18:05 ` Sverre Rabbelier
2011-08-22 21:27 ` Junio C Hamano
2011-08-22 21:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817231922.GA28966@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@owenstephens.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).