From: Jonathan Nieder <jrnieder@gmail.com>
To: Fredrik Kuivinen <frekui@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH resend] Makefile: Use computed header dependencies if the compiler supports it
Date: Thu, 18 Aug 2011 13:41:42 -0500 [thread overview]
Message-ID: <20110818184142.GF30436@elie.gateway.2wire.net> (raw)
In-Reply-To: <20110818183439.GA21560@fredrik-Q430-Q530>
Fredrik Kuivinen wrote:
> Oh, I missed "--help". But for me gcc always exits with status code 0
> when I give it "--help", regardless of what other flags I
> provide. Therefore, I don't see how "--help" can be used to test for
> support of -MMD.
Ah, my mistake. Good catch.
> Here is an updated patch. It avoids the ++empty.c file by giving "-x
> c" to the compiler.
Much nicer, thanks!
> It also avoids the auto-detection when
> COMPUTE_HEADER_DEPENDENCIES is set
Unfortunately "ifdef" in Makefiles means "if nonempty", so the
overhead of detection is still there if I want to explicitly disable
COMPUTE_HEADER_DEPENDENCIES. That's okay, since that overhead is
small. So for what it's worth,
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2011-08-18 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 18:45 [PATCH resend] Makefile: Use computed header dependencies if the compiler supports it Fredrik Kuivinen
2011-08-14 19:00 ` Jonathan Nieder
2011-08-14 19:53 ` Fredrik Kuivinen
2011-08-14 20:02 ` Jonathan Nieder
2011-08-18 18:34 ` Fredrik Kuivinen
2011-08-18 18:41 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818184142.GF30436@elie.gateway.2wire.net \
--to=jrnieder@gmail.com \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).