From: Eric Wong <normalperson@yhbt.net>
To: H Krishnan <hetchkay@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Using git-svn fetch after a directory change with rewrite-root
Date: Sat, 20 Aug 2011 19:18:37 +0000 [thread overview]
Message-ID: <20110820191837.GA30509@dcvr.yhbt.net> (raw)
In-Reply-To: <CANWsHyfHtr0EaJtNsDK9UTcmb_AbLg-1jUA-0uWJ-nEeNosb7w@mail.gmail.com>
(Apologies for the late response, I don't pay attention to
git svn much anymore. Feel free to Cc: me when posting to
the mailing list and remind me in a week if I forgot respond.)
H Krishnan <hetchkay@gmail.com> wrote:
> while (1) {
> # It is possible to tag two different subdirectories at
> # the same revision. If the url for an existing ref
> # does not match, we must either find a ref with a
> # matching url or create a new ref by growing a tail.
> $gs = Git::SVN->init($u, $p, $repo_id, $ref_id, 1);
> my (undef, $max_commit) = $gs->rev_map_max(1);
> last if (!$max_commit);
> my ($url) = ::cmt_metadata($max_commit);
> last if ($url eq $gs->full_url);
> $ref_id .= '-';
> }
> print STDERR "Initializing parent: $ref_id\n" unless $::_q > 1;
>
> I wonder if commit 3235b7053c45a734c1cdf9b117bda68b7ced29c9 handles
> rewrite-root correctly. Should the comparison be made with
> $gs->metadata_url instead of $gs->full_url?
I think you're right, can you submit a test case? Current
tests all pass with $gs->metadata_url so I can probably
push it out in a bit regardless.
--
Eric Wong
next prev parent reply other threads:[~2011-08-20 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 3:26 Using git-svn fetch after a directory change with rewrite-root H Krishnan
2011-08-10 13:22 ` H Krishnan
2011-08-16 11:26 ` Michael Schubert
2011-08-20 19:18 ` Eric Wong [this message]
2011-09-01 20:54 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110820191837.GA30509@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=hetchkay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).