From: Pete Wyckoff <pw@padd.com>
To: Vitor Antunes <vitor.hda@gmail.com>
Cc: git@vger.kernel.org, Tor Arvid Lund <torarvid@gmail.com>
Subject: Re: [PATCH v3 1/5] git-p4: Allow setting rename/copy detection threshold
Date: Mon, 22 Aug 2011 08:18:37 -0400 [thread overview]
Message-ID: <20110822121837.GA3761@arf.padd.com> (raw)
In-Reply-To: <1314001989-29017-2-git-send-email-vitor.hda@gmail.com>
vitor.hda@gmail.com wrote on Mon, 22 Aug 2011 09:33 +0100:
> Copy and rename detection arguments (-C and -M) allow setting a threshold value
> for the similarity ratio. If the similarity is below this threshold the rename
> or copy is ignored and the file is added as new.
> This patch allows setting git-p4.detectRenames and git-p4.detectCopies options
> to an integer value to set the respective threshold.
>
> Signed-off-by: Vitor Antunes <vitor.hda@gmail.com>
This series looks great. Thanks for fixing the --bool issue and
the tests.
Acked-by: Pete Wyckoff <pw@padd.com>
-- Pete
next prev parent reply other threads:[~2011-08-22 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 8:33 [PATCH v3 0/5] Support threshold in copy/rename detection Vitor Antunes
2011-08-22 8:33 ` [PATCH v3 1/5] git-p4: Allow setting rename/copy detection threshold Vitor Antunes
2011-08-22 12:18 ` Pete Wyckoff [this message]
2011-08-22 12:44 ` Vitor Antunes
2011-08-22 8:33 ` [PATCH v3 2/5] git-p4: Add description of rename/copy detection options Vitor Antunes
2011-08-22 8:33 ` [PATCH v3 3/5] git-p4: Add test case for rename detection Vitor Antunes
2011-08-22 8:33 ` [PATCH v3 4/5] git-p4: Add test case for copy detection Vitor Antunes
2011-08-22 8:33 ` [PATCH v3 5/5] git-p4: Process detectCopiesHarder with --bool Vitor Antunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822121837.GA3761@arf.padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=torarvid@gmail.com \
--cc=vitor.hda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).