From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
Elijah Newren <newren@gmail.com>,
Owen Stephens <git@owenstephens.co.uk>,
git@vger.kernel.org
Subject: Re: Malformed branch name in fast-export when specifying non-HEAD/branch revision
Date: Mon, 22 Aug 2011 17:32:14 -0400 [thread overview]
Message-ID: <20110822213214.GA14404@sigill.intra.peff.net> (raw)
In-Reply-To: <7vpqjxuogr.fsf@alter.siamese.dyndns.org>
On Mon, Aug 22, 2011 at 02:27:00PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Yeah, the behavior of your patch looks fine to me. I thought the point
> > in contention was that having export understand refspecs would fix a lot
> > of _other_ cases, too.
>
> Perhaps if we added refspecs we could cover other cases, too, but I do not
> think we need to require the patch to cover additional cases. The more
> problematic was that the particular implementation in the patch smelled
> bad.
OK. I didn't look at that at all. I just wanted to express my support
for "refspecs would solve other problems, too". :)
-Peff
prev parent reply other threads:[~2011-08-22 21:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAORuUR1viqG27+dYOFS_5SLxFOE2wHJqAQ3i3RByg_fbWACh-Q@mail.gmail.com>
2011-08-17 16:21 ` Malformed branch name in fast-export when specifying non-HEAD/branch revision Owen Stephens
2011-08-17 19:36 ` Elijah Newren
2011-08-17 22:30 ` Junio C Hamano
2011-08-17 23:19 ` Jeff King
2011-08-21 22:29 ` Sverre Rabbelier
2011-08-22 16:19 ` Jeff King
2011-08-22 16:54 ` Sverre Rabbelier
2011-08-22 17:57 ` Jeff King
2011-08-22 18:05 ` Sverre Rabbelier
2011-08-22 21:27 ` Junio C Hamano
2011-08-22 21:32 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822213214.GA14404@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@owenstephens.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).