From: Jeff King <peff@peff.net>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] remote: "rename o foo" should not rename ref "origin/bar"
Date: Wed, 31 Aug 2011 22:46:17 -0400 [thread overview]
Message-ID: <20110901024617.GD31838@sigill.intra.peff.net> (raw)
In-Reply-To: <1314841843-19868-2-git-send-email-martin.von.zweigbergk@gmail.com>
On Wed, Aug 31, 2011 at 09:50:43PM -0400, Martin von Zweigbergk wrote:
> When renaming a remote called 'o' using 'git remote rename o foo', git
> should also rename any remote-tracking branches for the remote. This
> does happen, but any remote-tracking branches starting with
> 'refs/remotes/o', such as 'refs/remotes/origin/bar', will also be
> renamed (to 'refs/remotes/foorigin/bar' in this case).
To be totally correct, shouldn't this check each ref against the RHS of
the remote's old refspec, and rename it according to the remote's new
refspec?
Maybe that is just being pedantic, though. This should work fine with
the default config[1].
-Peff
[1] Since this part of the renaming process obviously depends heavily on
refs/remotes/$OLD being the naming convention, shouldn't the
renaming of the refspecs do the same thing? I.e., it's another
reason that your patch 1/2 should only tweak refs/remotes/$OLD.
Otherwise you will get renamed refspecs, but the actual refs won't
be moved.
next prev parent reply other threads:[~2011-09-01 2:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 1:50 [PATCH 1/2] remote: write correct fetch spec when renaming remote 'remote' Martin von Zweigbergk
2011-09-01 1:50 ` [PATCH 2/2] remote: "rename o foo" should not rename ref "origin/bar" Martin von Zweigbergk
2011-09-01 2:46 ` Jeff King [this message]
2011-09-02 0:35 ` Martin von Zweigbergk
2011-09-02 15:55 ` Jeff King
2011-09-01 2:42 ` [PATCH 1/2] remote: write correct fetch spec when renaming remote 'remote' Jeff King
2011-09-01 3:18 ` Junio C Hamano
2011-09-02 0:02 ` Martin von Zweigbergk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901024617.GD31838@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).