From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Philip Oakley <philipoakley@iee.org>,
Hilco Wijbenga <hilco.wijbenga@gmail.com>,
Git Users <git@vger.kernel.org>
Subject: Re: Rebase & Trailing Whitespace
Date: Fri, 2 Sep 2011 04:28:51 -0400 [thread overview]
Message-ID: <20110902082851.GA17703@sigill.intra.peff.net> (raw)
In-Reply-To: <4E6086AA.40806@drmicha.warpmail.net>
On Fri, Sep 02, 2011 at 09:32:58AM +0200, Michael J Gruber wrote:
> > Thanks. By itself, I think many readers would ask "why would I want the
> > empty tree, so I threw in a few examples of use on the wiki, too.
>
> Ugh. I mean: Thanks for the wiki entries, they're nice, but have you
> checked git.git for whitespace errors? Time for another war on
> whitespace? Many false positives, of course, but also true positives.
Yeah, there are a lot. Because of the potential disruption to patches in
progress, though, we tend not to do big bulk updates of style changes.
But it may be worth using the
rm foo.c
git diff -R | git apply --whitespace=fix
trick if you are going to be working on foo.c. And if there are a lot,
you can "add -p" whatever fixes are appropriate for the area you're
working in.
-Peff
next prev parent reply other threads:[~2011-09-02 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 23:55 Rebase & Trailing Whitespace Hilco Wijbenga
2011-09-01 2:31 ` Jeff King
2011-09-01 21:00 ` Philip Oakley
2011-09-01 21:26 ` Jeff King
2011-09-02 7:32 ` Michael J Gruber
2011-09-02 8:28 ` Jeff King [this message]
2011-09-03 20:18 ` Clemens Buchacher
2011-09-09 19:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902082851.GA17703@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=hilco.wijbenga@gmail.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).