From: Clemens Buchacher <drizzd@aon.at>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
Philip Oakley <philipoakley@iee.org>,
Hilco Wijbenga <hilco.wijbenga@gmail.com>,
Git Users <git@vger.kernel.org>
Subject: Re: Rebase & Trailing Whitespace
Date: Sat, 3 Sep 2011 22:18:32 +0200 [thread overview]
Message-ID: <20110903201832.GB8362@ecki> (raw)
In-Reply-To: <20110902082851.GA17703@sigill.intra.peff.net>
On Fri, Sep 02, 2011 at 04:28:51AM -0400, Jeff King wrote:
>
> Yeah, there are a lot. Because of the potential disruption to patches in
> progress, though, we tend not to do big bulk updates of style changes.
> But it may be worth using the
>
> rm foo.c
> git diff -R | git apply --whitespace=fix
I am looking at the output of:
git diff --check 4b825 -- $(git ls-files '*.[ch]'|grep -v ^compat)
Most of those are false positives from multiline function argument
lists, which are aligned with the first line. So the above command
would break more than it would fix.
I don't care either way, but for future reference: Do we or do we
not want indentation with spaces in this case?
Clemens
next prev parent reply other threads:[~2011-09-03 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 23:55 Rebase & Trailing Whitespace Hilco Wijbenga
2011-09-01 2:31 ` Jeff King
2011-09-01 21:00 ` Philip Oakley
2011-09-01 21:26 ` Jeff King
2011-09-02 7:32 ` Michael J Gruber
2011-09-02 8:28 ` Jeff King
2011-09-03 20:18 ` Clemens Buchacher [this message]
2011-09-09 19:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110903201832.GB8362@ecki \
--to=drizzd@aon.at \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=hilco.wijbenga@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).