git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michal Sojka <sojka@os.inf.tu-dresden.de>
Cc: git@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH v4] gitk: Allow commit editing
Date: Wed, 7 Sep 2011 16:10:11 -0400	[thread overview]
Message-ID: <20110907201011.GF13364@sigill.intra.peff.net> (raw)
In-Reply-To: <87fwknaveh.fsf@steelpick.2x.cz>

On Sat, Aug 27, 2011 at 02:31:02PM +0200, Michal Sojka wrote:

> Here is a new version with the micro-optimization.
> 
> Another minor change is that this patch now applies to gitk repo
> (http://git.kernel.org/pub/scm/gitk/gitk.git) instead of the main git
> repo.

Thanks. This version fixes most of my complaints and looks reasonable
sane, as long as you accept the idea that starting an interactive rebase
behind the scenes is sane.  I'm still not 100% convinced. But then, I am
not a big gitk user, either (I like visualizing with it, but I rarely
want to do anything interactive). So I'll leave Paul and anyone else to
argue or make a decision on that count.

-Peff

  reply	other threads:[~2011-09-07 20:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 19:56 [PATCH RFC] gitk: Allow commit editing Michal Sojka
2011-08-18 22:33 ` Jeff King
2011-08-19 11:44   ` Chris Packham
2011-08-19 13:34     ` Michal Sojka
2011-08-19 14:40       ` Michal Sojka
2011-08-19 12:23   ` Michal Sojka
2011-08-19 12:25     ` [PATCH] " Michal Sojka
2011-08-25  3:14       ` Jeff King
2011-08-25 13:15         ` [PATCH v3] " Michal Sojka
2011-08-25 17:30           ` Jeff King
2011-08-27 12:31             ` [PATCH v4] " Michal Sojka
2011-09-07 20:10               ` Jeff King [this message]
2011-09-08 20:59               ` Paul Mackerras
2011-09-13 23:11                 ` Michal Sojka
2011-08-25  3:07     ` [PATCH RFC] " Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110907201011.GF13364@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=sojka@os.inf.tu-dresden.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).