git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Jeff King <peff@peff.net>
Cc: Brian Gernhardt <benji@silverinsanity.com>,
	Git List <git@vger.kernel.org>
Subject: Re: t0300-credentials: poll failed: invalid argument
Date: Fri, 9 Sep 2011 16:13:13 +0200	[thread overview]
Message-ID: <201109091613.13137.trast@student.ethz.ch> (raw)
In-Reply-To: <20110829174309.GA11524@sigill.intra.peff.net>

Jeff King wrote:
> On Mon, Aug 29, 2011 at 01:28:05PM -0400, Brian Gernhardt wrote:
> 
> > > Ugh, sorry, this is my fault. The check_expiration() function can return
> > > a totally bogus value before we actually get any credentials.
> > > 
> > > Does this patch fix it for you?
> > 
> > Yes it does!  Surprisingly enough, non-bogus parameters keeps poll
> > from erroring with EINVAL.  Funny that.  ;-)
> 
> Great. I'm working on a few more patches on top of that topic, so I'll
> add it to my list to send out in the next day or so.

I'm still seeing this with current pu (from repo.or.cz), but only on
OS X

  $ uname -a
  Darwin mackeller.inf.ethz.ch 11.1.0 Darwin Kernel Version 11.1.0: Tue Jul 26 16:07:11 PDT 2011; root:xnu-1699.22.81~1/RELEASE_X86_64 x86_64

Where "this" is:

  --- expect-stderr       2011-09-09 14:12:13.000000000 +0000
  +++ stderr      2011-09-09 14:12:13.000000000 +0000
  @@ -1,2 +1,3 @@
   askpass: Username:
   askpass: Password:
  +fatal: poll failed: Invalid argument

for each of the tests 15--19.  Is it supposed to be fixed?

I don't have time to look into it without knowing what to search for,
but if you want me to test anything on that OS X just ask.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2011-09-09 14:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-28  4:40 t0300-credentials: poll failed: invalid argument Brian Gernhardt
2011-08-29 17:14 ` Jeff King
2011-08-29 17:28   ` Brian Gernhardt
2011-08-29 17:43     ` Jeff King
2011-09-09 14:13       ` Thomas Rast [this message]
2011-09-14  8:15         ` Thomas Rast
2011-09-14 14:24           ` Brian Gernhardt
2011-09-14 14:49             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109091613.13137.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).