From: Jeff King <peff@peff.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Junio C Hamano" <gitster@pobox.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: "git archive" seems to be broken wrt zip files
Date: Sun, 11 Sep 2011 02:22:06 -0400 [thread overview]
Message-ID: <20110911062206.GA29620@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+55aFx43OxExGNrJs+AyKNtdr+KCZZoE=iaQTz8uHoUSrQv0w@mail.gmail.com>
On Sat, Sep 10, 2011 at 09:58:08PM -0700, Linus Torvalds wrote:
> So I wouldn't ever have noticed on my own, but now that I've tried
> github for the kernel, somebody else reported that the downloaded zip
> file (seriously? the kernel as a zip file?) is corrupt.
>
> And it doesn't really seem to be a github issue. I can re-create it
> with a simple
>
> git archive --format=zip HEAD -o ../kernel.zip
>
> on my kernel repository: the end result does not unzip correctly:
Hmm. I can easily replicate the problem here, but interestingly it does
not happen with sub-trees like:
git archive --format=zip HEAD:drivers -o ../kernel.zip
Going back in history, I can replicate it with René's 62cdce1
(git-archive --format=zip: add symlink support, 2006-10-07). So there's
nothing to bisect.
Cc'ing René.
-Peff
next prev parent reply other threads:[~2011-09-11 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 4:58 "git archive" seems to be broken wrt zip files Linus Torvalds
2011-09-11 6:22 ` Jeff King [this message]
2011-09-11 6:27 ` Jeff King
2011-09-11 13:14 ` Andreas Schwab
2011-09-11 15:38 ` René Scharfe
[not found] ` <CA+55aFxsaE5btVJmM_QaUMcDzBg4df-g8X7NknC6t9UM+oQATw@mail.gmail.com>
2011-09-14 6:55 ` Linus Torvalds
2011-09-14 8:32 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110911062206.GA29620@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).