git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: John Szakmeister <john@szakmeister.net>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Boaz Harrosh <bharrosh@panasas.com>,
	Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>,
	Thomas Rast <trast@student.ethz.ch>,
	Alexey Shumkin <zapped@mail.ru>
Subject: Re: What's cooking in git.git (Sep 2011, #04; Mon, 12)
Date: Tue, 13 Sep 2011 13:20:55 -0400	[thread overview]
Message-ID: <20110913172055.GD32251@sigill.intra.peff.net> (raw)
In-Reply-To: <4E6F70E6.2070602@sunshineco.com>

On Tue, Sep 13, 2011 at 11:04:06AM -0400, Eric Sunshine wrote:

> >Or maybe not there at all?  We tend to do quite a bit with Matlab, and
> >Matlab scripts also end in ".m".  Unfortunately, it bears little
> >resemblance to Objective-C.
> 
> This default mapping is provided as a convenience only. Users can
> edit .gitattributes as needed. If we assume that the number of
> Macintosh and iOS (iPhone, iPad, iPod Touch) programmers heavily
> outweighs the number of Matlab users, then the convenience of having
> .m in the default list may be justified.

Yeah, but the cost of being wrong may be much higher than the cost of
just using the default.

> It also is reasonable to ask if the "*.m diff=objc" mapping actually
> produces an inferior diff hunk-header[1] for Matlab files than when
> "diff=objc" is not present.

I think this is the important question. Is it inferior, and how bad does
it look? And then we can weigh that against the convenience of not
having to specify objc files in gitattributes.

-Peff

  reply	other threads:[~2011-09-13 17:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-12 20:16 What's cooking in git.git (Sep 2011, #04; Mon, 12) Junio C Hamano
2011-09-12 21:48 ` Junio C Hamano
2011-09-12 21:51 ` Junio C Hamano
2011-09-12 23:27   ` Jeff King
2011-09-13  0:09     ` Junio C Hamano
2011-09-13  9:24       ` Nguyen Thai Ngoc Duy
2011-09-12 21:53 ` Junio C Hamano
2011-09-13  7:32   ` [PATCH v2] Documentation: basic configuration of notes.rewriteRef Thomas Rast
2011-09-13 17:16     ` Junio C Hamano
2011-09-13 17:18     ` Jeff King
2011-09-12 21:55 ` What's cooking in git.git (Sep 2011, #04; Mon, 12) Junio C Hamano
2011-09-12 21:59 ` Junio C Hamano
2011-09-14  2:34   ` Jonathon Mah
2011-09-14 20:57     ` Junio C Hamano
2011-09-16  2:12       ` [PATCH] mergetool: Use args as pathspec to unmerged files Jonathon Mah
2011-09-16 20:17         ` Junio C Hamano
2011-09-25  0:45           ` David Aguilar
2011-09-26 16:40             ` Junio C Hamano
2011-09-12 22:02 ` What's cooking in git.git (Sep 2011, #04; Mon, 12) Junio C Hamano
2011-09-12 23:15   ` Sverre Rabbelier
2011-09-12 22:56 ` Junio C Hamano
2011-09-13  9:46   ` Erik Faye-Lund
2011-09-29 12:03     ` Pascal Obry
2011-09-12 22:58 ` Junio C Hamano
2011-09-13 12:05   ` Michael J Gruber
     [not found] ` <7vk49d5t8u.fsf@alter.siamese.dyndns.org>
2011-09-12 23:15   ` Eric Sunshine
2011-09-12 23:25     ` Junio C Hamano
2011-09-12 23:33       ` Jeff King
2011-09-12 23:53         ` Jeff King
2011-09-13 15:15         ` Brandon Casey
2011-09-13 16:05           ` Jeff King
2011-09-13 16:22             ` Brandon Casey
2011-09-13  7:51     ` John Szakmeister
2011-09-13 15:04       ` Eric Sunshine
2011-09-13 17:20         ` Jeff King [this message]
2011-09-12 23:35   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110913172055.GD32251@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=bharrosh@panasas.com \
    --cc=brandon.casey.ctr@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@szakmeister.net \
    --cc=sunshine@sunshineco.com \
    --cc=trast@student.ethz.ch \
    --cc=zapped@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).