From: Jonathan Nieder <jrnieder@gmail.com>
To: Dmitry Ivankov <divanorama@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
David Barr <davidbarr@google.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH/RFC 0/2] fast-import: commit from null_sha1
Date: Sun, 18 Sep 2011 16:30:50 -0500 [thread overview]
Message-ID: <20110918213050.GJ2308@elie> (raw)
In-Reply-To: <1316380846-15845-1-git-send-email-divanorama@gmail.com>
Dmitry Ivankov wrote:
> These patches make fast-import treat
> commit refs/heads/master
> ...
> from `null_sha1`
> like any other missing parent sha1 - reject such input.
Are you sure the existing support for "from 0{40}" is not deliberate
and that no one is relying on it? If and only if you are, then this
seems like a good idea (a single patch that both makes the behavior
change and adds a test for it should be easier to review).
next prev parent reply other threads:[~2011-09-18 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 21:20 [PATCH/RFC 0/2] fast-import: commit from null_sha1 Dmitry Ivankov
2011-09-18 21:20 ` [PATCH 1/2] fast-import: add 'commit from 0{40}' failing test Dmitry Ivankov
2011-09-18 21:20 ` [PATCH 2/2] fast-import: fix 'from 0{40}' test Dmitry Ivankov
2011-09-18 21:30 ` Jonathan Nieder [this message]
2011-09-18 21:40 ` [PATCH/RFC 0/2] fast-import: commit from null_sha1 Dmitry Ivankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110918213050.GJ2308@elie \
--to=jrnieder@gmail.com \
--cc=davidbarr@google.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).