From: Josh Triplett <josh@joshtriplett.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Clemens Buchacher <drizzd@aon.at>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
Robert Suetterlin <robert@mpe.mpg.de>,
Paul Mackerras <paulus@samba.org>,
git@vger.kernel.org
Subject: Re: gitk: 'j' and 'k' keyboard shortcuts backward
Date: Mon, 19 Sep 2011 10:11:56 -0700 [thread overview]
Message-ID: <20110919171156.GA1705@leaf> (raw)
In-Reply-To: <20110919164950.GB2861@elie>
On Mon, Sep 19, 2011 at 11:49:50AM -0500, Jonathan Nieder wrote:
> How about this patch?
>
> -- >8 --
> Subject: gitk: Make vi-style keybindings more vi-like
>
> When commit 6e2dda35 (Add new keybindings, 2005-09-22) added vi-style
> keybindings to gitk (an excellent idea!), instead of adopting the
> usual "hjkl = left, down, up, right" bindings used by less, vi, rogue,
> and many other programs, it used "ijkl = up, left, down, right" to
> mimic the inverted-T formation of the arrow keys on a qwerty keyboard,
> in the style of Lode runner. So using 'j' and 'k' to scroll through
> commits produces utterly confusing results to the vi user, as 'k'
> moves down and 'j' moves to the previous commit.
>
> Luckily most non-vi-users are probably using an alternate set of keys
> (cursor keys or z/x + n/p) anyway. Switch to the expected vi/nethack
> convention.
>
> Requested-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
This looks perfect to me.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks!
- Josh Triplett
next prev parent reply other threads:[~2011-09-19 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+Jd1rFzOOxL+-JVeovTiOwM5cmyyis65Y1+xiDmG=tkJ3b2Xw@mail.gmail.com>
2011-09-19 16:49 ` gitk: 'j' and 'k' keyboard shortcuts backward Jonathan Nieder
2011-09-19 17:11 ` Josh Triplett [this message]
2011-09-19 18:04 ` Clemens Buchacher
2011-09-19 22:05 ` Klaus Robert Suetterlin
2011-10-08 7:04 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919171156.GA1705@leaf \
--to=josh@joshtriplett.org \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=patthoyts@users.sourceforge.net \
--cc=paulus@samba.org \
--cc=robert@mpe.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).