From: Jakub Narebski <jnareb@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Drew Northup <drew.northup@maine.edu>,
John 'Warthog9' Hawley <warthog9@kernel.org>,
admin@repo.or.cz
Subject: Re: [PATCH/RFCv4 1/4] Documentation: Preparation for gitweb manpages
Date: Tue, 20 Sep 2011 02:10:12 +0200 [thread overview]
Message-ID: <201109200210.13772.jnareb@gmail.com> (raw)
In-Reply-To: <20110919233703.GF6343@elie>
Thanks a lot for all language fixes.
Nb. I'll respond to other comments separately.
On Tue, 20 Sep 2011, Jonathan Nieder wrote:
> Jakub Narebski wrote:
> > This way to build gitweb documentation one can use
> >
> > make -C gitweb doc
> >
> > or
> >
> > cd gitweb; make doc
Actually it should read "to build only gitweb documentation"...
> Does "make -CDocumentation man html" build the gitweb documentation,
> too (and "make install-doc" install it)?
>
> [...]
> > --- a/Documentation/Makefile
> > +++ b/Documentation/Makefile
> > @@ -170,6 +170,9 @@ info: git.info gitman.info
> >
> > pdf: user-manual.pdf
> >
> > +GITWEB_DOC = $(filter gitweb.%,$(DOC_HTML) $(DOC_MAN1) $(DOC_MAN5) $(DOC_MAN7))
> > +gitweb-doc: $(GITWEB_DOC)
>
> Looks like no, alas.
... because of the fact that gitweb.txt is in DOC_MAN1, and gitweb.conf.txt
is in DOC_MAN5, then 'make doc' would among others build gitweb
documentation. 'make -C Documentation gitweb-doc' / 'make -C gitweb doc'
just builds a _subset_ of said documentation.
>
> Except for that detail, this looks good.
Nb. what is also missing is having links to gitweb(1) and gitweb.conf(5)
in git(1) manpages together with the rest.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-09-20 0:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 13:34 [PATCH/RFCv4 0/4] Moving gitweb documentation to manpages Jakub Narebski
2011-09-18 13:34 ` [PATCH/RFCv4 1/4] Documentation: Preparation for gitweb manpages Jakub Narebski
2011-09-19 23:37 ` Jonathan Nieder
2011-09-20 0:10 ` Jakub Narebski [this message]
2011-09-20 20:11 ` Jakub Narebski
2011-09-20 20:19 ` Jonathan Nieder
2011-09-20 20:33 ` Jakub Narebski
2011-09-18 13:34 ` [PATCH/RFCv4 2/4] gitweb: Add manpage for /etc/gitweb.conf (for gitweb documentation) Jakub Narebski
2011-09-20 4:41 ` Jonathan Nieder
2011-09-22 13:41 ` Jakub Narebski
2011-09-18 13:34 ` [PATCH/RFCv4 3/4] gitweb: Add manpage for gitweb Jakub Narebski
2011-09-18 13:34 ` [PATCH/RFCv4 4/4] gitweb: Add gitweb manpages to 'gitweb' package in git.spec Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109200210.13772.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=admin@repo.or.cz \
--cc=drew.northup@maine.edu \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).