From: Jonathan Nieder <jrnieder@gmail.com>
To: Dmitry Ivankov <divanorama@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
David Barr <davidbarr@google.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH 0/8] fast-import: cache oe more often
Date: Tue, 20 Sep 2011 09:39:41 -0500 [thread overview]
Message-ID: <20110920143941.GE7517@elie> (raw)
In-Reply-To: <CA+gfSn-nh4BhCPf6m8+EN0zo=BuhxRNLcLBx7ynRWPA=GxfDyg@mail.gmail.com>
Dmitry Ivankov wrote:
> The next step would be to replace sha1 with struct object_entry* in fast-import.
> So it'll be in struct tree_entry (twice, for each of versions[2]),
> branch, tag, hash_list (used to store merge from lists), last_object.
> Then some fields will be deleted as they can be accessed from
> object_entry:
> last_object->depth
> last_object->offset
> tree_content->delta_depth
> branch,tag->pack_id
>
> And it all even slightly decreased memory consumption (checked some
> time ago, but think it's still true).
Yes, that sounds interesting, so:
[...]
> In short, if there is nothing bad with this patchset, it'll be
> absolutely natural one after switch to oe instead of sha1, but it's
> put before to split the big series. And of course this part may have a
> small speedup of it's own. If it's not too good to be accepted on it's
> own, I'll just include it into future series depending on it.
It would be indeed be more natural to review a single series that
combines this preparation with the change it prepares for. (And the
change descriptions should explain on their own why they are
individually justified or what project they are contributing towards.)
My question was actually about this last point you made in the
second-to-last sentence: have you measured the speedup produced by the
patches you already sent? I didn't think carefully about it, but my
first thought was that it might slow things down as the internal hash
tables (which still seem to be fixed-size in mainline git) start to
fill up.
prev parent reply other threads:[~2011-09-20 14:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 1:27 [PATCH 0/8] fast-import: cache oe more often Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 1/8] fast-import: cache oe in file_change_m Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 2/8] fast-import: cache oe in parse_new_tag Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 3/8] fast-import: cache oe in note_change_n Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 4/8] fast-import: extract common sha1_file access functions Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 5/8] fast-import: tiny optimization in read_marks Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 6/8] fast-import: cache oe in load_tree Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 7/8] fast-import: cache oe in cat_blob Dmitry Ivankov
2011-09-19 1:27 ` [PATCH 8/8] fast-import: cache objects while dereferencing Dmitry Ivankov
2011-09-20 4:02 ` [PATCH 0/8] fast-import: cache oe more often Junio C Hamano
2011-09-20 4:26 ` Jonathan Nieder
2011-09-20 7:17 ` Dmitry Ivankov
2011-09-20 14:39 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920143941.GE7517@elie \
--to=jrnieder@gmail.com \
--cc=davidbarr@google.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).