From: Alexey Shumkin <zapped@mail.ru>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] format-patch: cover letter does not respect i18n.commitencoding
Date: Tue, 20 Sep 2011 23:55:05 +0400 [thread overview]
Message-ID: <20110920235505.26fb6501@zappedws> (raw)
In-Reply-To: <7v62kn6mqi.fsf@alter.siamese.dyndns.org>
> Alexey Shumkin <zapped@mail.ru> writes:
>
> > diff --git a/builtin/log.c b/builtin/log.c
> > index 5c2af59..6a4050c 100644
> > --- a/builtin/log.c
> > +++ b/builtin/log.c
> > @@ -769,7 +769,7 @@ static void make_cover_letter(struct rev_info
> > *rev, int use_stdout, struct shortlog log;
> > struct strbuf sb = STRBUF_INIT;
> > int i;
> > - const char *encoding = "UTF-8";
> > + const char *encoding = get_commit_output_encoding();
>
> Hmm, I have a feeling that this should use log output encoding. Am I
> mistaken?
Oooh! I made a mistake. I'm sorry
get_log_output_encoding must be used instead, yes
> The i18n.commitencoding variable is about the internal representation
> in the object [*1*] that is to be converted from the encoding of the
> original e-mail message which could be different.
> i18n.logoutputencoding is to externalize it [*2*].
>
> [Footnotes]
>
> *1* f1f909e (mailinfo: Use i18n.commitencoding, 2005-11-27)
> *2* a731ec5 (t3901: test "format-patch | am" pipe with i18n,
> 2007-01-13)
>
prev parent reply other threads:[~2011-09-20 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 8:26 [PATCH] format-patch: cover letter does not respect i18n.commitencoding Alexey Shumkin
2011-09-20 19:24 ` Junio C Hamano
2011-09-20 19:55 ` Alexey Shumkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920235505.26fb6501@zappedws \
--to=zapped@mail.ru \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).