From: Thomas Rast <trast@student.ethz.ch>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
<cmn@elego.de>, A Large Angry SCM <gitzilla@gmail.com>,
Daniel Barkalow <barkalow@iabervon.org>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH v3 13/22] resolve_ref(): turn buffer into a proper string as soon as possible
Date: Fri, 23 Sep 2011 10:17:55 +0200 [thread overview]
Message-ID: <201109231017.55996.trast@student.ethz.ch> (raw)
In-Reply-To: <1316121043-29367-14-git-send-email-mhagger@alum.mit.edu>
Hi Michael
Michael Haggerty wrote:
> Immediately strip off trailing spaces and null-terminate the string
> holding the contents of the reference file; this allows the use of
> string functions and avoids the need to keep separate track of the
> string's length. (get_sha1_hex() fails automatically if the string is
> too short.)
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
I'm getting valgrind failures in t1450-fsck and t3800-mktag which
blame to this commit. For t1450 it looks as follows:
ok 5 - object with bad sha1
expecting success:
git rev-parse HEAD^{tree} >.git/refs/heads/invalid &&
test_when_finished "git update-ref -d refs/heads/invalid" &&
git fsck 2>out &&
cat out &&
grep "not a commit" out
==19623== Use of uninitialised value of size 8
==19623== at 0x4B6747: hexval (cache.h:798)
==19623== by 0x4B6797: get_sha1_hex (hex.c:42)
==19623== by 0x4DD12A: resolve_ref (refs.c:588)
==19623== by 0x4DC777: get_ref_dir (refs.c:313)
==19623== by 0x4DC6FA: get_ref_dir (refs.c:302)
==19623== by 0x4DC963: get_loose_refs (refs.c:368)
==19623== by 0x4DD556: do_for_each_ref (refs.c:687)
==19623== by 0x4DDA05: for_each_replace_ref (refs.c:806)
==19623== by 0x4E5CE9: prepare_replace_object (replace_object.c:86)
==19623== by 0x4E5D3C: do_lookup_replace_object (replace_object.c:103)
==19623== by 0x4C99BB: lookup_replace_object (cache.h:764)
==19623== by 0x4C9FA6: parse_object (object.c:191)
==19623== Uninitialised value was created by a stack allocation
==19623== at 0x4DCE34: resolve_ref (refs.c:498)
or when I run it at the tip of pu instead of at the commit itself,
line numbers are like so:
==2308== Use of uninitialised value of size 8
==2308== at 0x4ADB8B: get_sha1_hex (cache.h:800)
==2308== by 0x4D4283: resolve_ref (refs.c:629)
==2308== by 0x4D4851: get_ref_dir (refs.c:361)
==2308== by 0x4D48C6: get_ref_dir (refs.c:350)
==2308== by 0x4D4D29: do_for_each_ref (refs.c:412)
==2308== by 0x4DCD93: do_lookup_replace_object (replace_object.c:86)
==2308== by 0x4C31F4: parse_object (cache.h:764)
==2308== by 0x4F2A1D: get_sha1_1 (sha1_name.c:567)
==2308== by 0x4F2D5F: get_sha1_with_context_1 (sha1_name.c:1117)
==2308== by 0x4F3543: get_sha1 (cache.h:822)
==2308== by 0x461B50: cmd_rev_parse (rev-parse.c:723)
==2308== by 0x404B71: run_builtin (git.c:308)
==2308== Uninitialised value was created by a stack allocation
==2308== at 0x4D4006: resolve_ref (refs.c:530)
Can you look into this?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-09-23 8:18 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 21:10 [PATCH v3 00/22] Clean up refname checks and normalization Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 01/22] t1402: add some more tests Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 02/22] git check-ref-format: add options --allow-onelevel and --refspec-pattern Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 03/22] Change bad_ref_char() to return a boolean value Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 04/22] Change check_ref_format() to take a flags argument Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 05/22] Refactor check_refname_format() Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 06/22] Do not allow ".lock" at the end of any refname component Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 07/22] Make collapse_slashes() allocate memory for its result Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 08/22] Inline function refname_format_print() Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 09/22] Change check_refname_format() to reject unnormalized refnames Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 10/22] resolve_ref(): explicitly fail if a symlink is not readable Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 11/22] resolve_ref(): use prefixcmp() Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 12/22] resolve_ref(): only follow a symlink that contains a valid, normalized refname Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 13/22] resolve_ref(): turn buffer into a proper string as soon as possible Michael Haggerty
2011-09-23 8:17 ` Thomas Rast [this message]
2011-09-23 13:11 ` Michael Haggerty
2011-09-23 13:38 ` [PATCH 1/1] get_sha1_hex(): do not read past a NUL character Michael Haggerty
2011-09-23 18:59 ` Junio C Hamano
2011-10-05 19:11 ` Thomas Rast
2011-10-05 20:37 ` Junio C Hamano
2011-09-15 21:10 ` [PATCH v3 14/22] resolve_ref(): extract a function get_packed_ref() Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 15/22] resolve_ref(): do not follow incorrectly-formatted symbolic refs Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 16/22] remote: use xstrdup() instead of strdup() Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 17/22] remote: avoid passing NULL to read_ref() Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 18/22] resolve_ref(): verify that the input refname has the right format Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 19/22] resolve_ref(): emit warnings for improperly-formatted references Michael Haggerty
2011-10-11 16:16 ` Jeff King
2011-10-11 17:53 ` Junio C Hamano
2011-10-11 18:07 ` Junio C Hamano
2011-10-11 20:14 ` Re* " Junio C Hamano
2011-10-11 20:39 ` Jeff King
2011-10-11 21:31 ` Junio C Hamano
2011-10-11 22:54 ` Jeff King
2011-10-12 16:52 ` Junio C Hamano
2011-10-11 23:07 ` Jeff King
2011-10-11 23:50 ` Junio C Hamano
2011-10-12 2:11 ` Jeff King
2011-10-12 4:41 ` Junio C Hamano
2011-10-12 4:50 ` Jeff King
2011-10-12 17:48 ` [PATCH 1/2] refs.c: move dwim_ref()/dwim_log() from sha1_name.c Junio C Hamano
2011-10-12 17:49 ` [PATCH 2/2] Restrict ref-like names immediately below $GIT_DIR Junio C Hamano
2011-10-12 18:01 ` Michael Haggerty
2011-10-12 18:07 ` Junio C Hamano
2011-10-12 21:42 ` Michael Haggerty
2011-10-12 22:26 ` Junio C Hamano
2011-10-19 5:28 ` Junio C Hamano
2011-10-19 6:19 ` Junio C Hamano
2011-10-19 15:18 ` Michael Haggerty
2011-10-19 17:10 ` Junio C Hamano
2011-10-19 19:29 ` Junio C Hamano
2011-10-19 19:39 ` [PATCH] resolve_ref(): report breakage to the caller without warning Junio C Hamano
2011-10-19 20:31 ` [PATCH 2/2] Restrict ref-like names immediately below $GIT_DIR Michael Haggerty
2011-10-19 20:39 ` Junio C Hamano
2011-10-12 21:51 ` Jeff King
2011-10-12 2:56 ` Re* [PATCH v3 19/22] resolve_ref(): emit warnings for improperly-formatted references Michael Haggerty
2011-10-12 19:20 ` Junio C Hamano
2011-10-12 19:26 ` Jeff King
2011-09-15 21:10 ` [PATCH v3 20/22] resolve_ref(): also treat a too-long SHA1 as invalid Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 21/22] resolve_ref(): expand documentation Michael Haggerty
2011-09-15 21:10 ` [PATCH v3 22/22] add_ref(): verify that the refname is formatted correctly Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109231017.55996.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=barkalow@iabervon.org \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitzilla@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).