From: Cord Seele <cowose@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>,
Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH 2/2] use new Git::config_path() for aliasesfile
Date: Fri, 30 Sep 2011 23:16:33 +0200 [thread overview]
Message-ID: <20110930211633.GE13435@laptop> (raw)
In-Reply-To: <7vsjndoldq.fsf@alter.siamese.dyndns.org>
On Fri 30 Sep 2011 12:55:45 -0700, Junio C Hamano <gitster@pobox.com> wrote:
> I think the addition of "config --path" support is a good idea, but the
> resulting code suffers from too many cut&paste cruft across the config*
> family of methods.
>
> How about doing a bit of refactoring, perhaps something like this, on top
> as a separate patch?
Sound very reasonable to me - unfortunately it's beyond my perl-scope to be of
much help here.
-- Cord
next prev parent reply other threads:[~2011-09-30 21:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 13:13 [PATCH] git-send-email.perl: expand filename of aliasesfile Cord Seele
2011-09-28 13:42 ` Matthieu Moy
2011-09-28 14:40 ` Cord Seele
2011-09-28 14:47 ` Matthieu Moy
2011-09-30 10:52 ` [PATCH v2] git-send-email: allow filename expansion Cord Seele
2011-09-30 10:52 ` [PATCH 1/2] Add Git::config_path() Cord Seele
2011-10-07 20:32 ` Jakub Narebski
2011-10-07 21:35 ` Junio C Hamano
2011-10-07 21:44 ` Jakub Narebski
2011-10-07 22:26 ` Junio C Hamano
2011-09-30 10:52 ` [PATCH 2/2] use new Git::config_path() for aliasesfile Cord Seele
2011-09-30 19:55 ` Junio C Hamano
2011-09-30 21:16 ` Cord Seele [this message]
2011-09-30 22:00 ` Jakub Narebski
2011-09-30 22:18 ` Junio C Hamano
2011-10-07 21:17 ` [PATCH/RFC 3/2] Refactor Git::config_* Jakub Narebski
2011-10-17 20:50 ` Junio C Hamano
2011-10-17 21:47 ` Jakub Narebski
2011-10-17 23:25 ` Junio C Hamano
2011-10-18 9:47 ` [PATCH/RFC 3/2 (fixed)] " Jakub Narebski
2011-10-18 19:52 ` Junio C Hamano
2011-10-18 22:09 ` [PATCH/RFC 3/2 v3] " Jakub Narebski
2011-10-18 23:25 ` Junio C Hamano
2011-10-19 0:19 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930211633.GE13435@laptop \
--to=cowose@googlemail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).