From: Jeff King <peff@peff.net>
To: "Carlos Martín Nieto" <cmn@elego.de>
Cc: Jakub Narebski <jnareb@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: 6d4bb3833c3d2114d (fetch: verify we have everything we need before updating our ref) breaks fetch
Date: Sat, 1 Oct 2011 02:03:53 -0400 [thread overview]
Message-ID: <20111001060353.GA25228@sigill.intra.peff.net> (raw)
In-Reply-To: <1317426849.4331.29.camel@centaur.lab.cmartin.tk>
On Sat, Oct 01, 2011 at 01:54:08AM +0200, Carlos Martín Nieto wrote:
> > Have you tried
> >
> > $ ./git fetch git://repo.or.cz/git
>
> But this would execute /usr/local/libexec/git-fetch, wouldn't it? That
> is precisely what I don't want to execute, because I changed some code
> in builtin/fetch.c that I want to test.
No, but only because fetch is a builtin. However, it still doesn't set
up exec_path correctly, so your rev-list problem would not go away.
> I guess I'll have to either properly install git from 'next' or base my
> changed on 'maint'
Just use bin-wrappers/git. That's exactly what it's there for (and it's
what the test scripts use to make sure we are testing what is compiled).
Your change isn't the problem; only your testing method.
-Peff
next prev parent reply other threads:[~2011-10-01 6:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 16:04 6d4bb3833c3d2114d (fetch: verify we have everything we need before updating our ref) breaks fetch Carlos Martín Nieto
2011-09-28 18:50 ` Junio C Hamano
2011-09-28 18:53 ` Jeff King
2011-09-30 23:48 ` Carlos Martín Nieto
2011-09-28 19:12 ` Jakub Narebski
2011-09-30 23:54 ` Carlos Martín Nieto
2011-10-01 6:03 ` Jeff King [this message]
2011-10-01 10:38 ` Philip Oakley
2011-10-01 10:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111001060353.GA25228@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).