From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Petr Salinger <Petr.Salinger@seznam.cz>
Subject: Re: [PATCH] Makefile: do not set setgid bit on directories on GNU/kFreeBSD
Date: Mon, 3 Oct 2011 02:19:49 -0500 [thread overview]
Message-ID: <20111003071949.GC17289@elie> (raw)
In-Reply-To: <20111003064120.GA24396@elie>
Jonathan Nieder wrote:
> Since the setgid bit would only mean "do what you were going to do
> already", it's better to avoid setting it. Accordingly, ever since
> v1.5.5-rc0~59^2 (Do not use GUID on dir in git init --share=all on
> FreeBSD, 2008-03-05), git on true FreeBSD has done exactly that. Set
> DIR_HAS_BSD_GROUP_SEMANTICS in the makefile for GNU/kFreeBSD, too, so
> machines that use glibc with the kernel of FreeBSD get the same fix.
[...]
> Sorry to have taken so long to send this one out. Anyway, it seems
> to me like the right thing to do. Petr, what do you think?
fwiw:
Acked-by: Petr Salinger <Petr.Salinger@seznam.cz>
Thanks for looking it over.
next prev parent reply other threads:[~2011-10-03 7:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 6:41 [PATCH] Makefile: do not set setgid bit on directories on GNU/kFreeBSD Jonathan Nieder
2011-10-03 7:19 ` Jonathan Nieder [this message]
2011-10-03 19:16 ` Junio C Hamano
2011-10-03 19:19 ` Sverre Rabbelier
2011-10-03 19:42 ` Jonathan Nieder
2011-10-22 11:11 ` Jonathan Nieder
2011-10-24 23:07 ` Greg Troxel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003071949.GC17289@elie \
--to=jrnieder@gmail.com \
--cc=Petr.Salinger@seznam.cz \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).