From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Teemu Matilainen <teemu.matilainen@iki.fi>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 1/3] completion: unite --reuse-message and --reedit-message handling
Date: Sat, 8 Oct 2011 03:04:32 +0200 [thread overview]
Message-ID: <20111008010432.GA11561@goldbirke> (raw)
In-Reply-To: <7vd3e9yap7.fsf@alter.siamese.dyndns.org>
Hi,
On Thu, Oct 06, 2011 at 04:14:28PM -0700, Junio C Hamano wrote:
> All three patches make sense to me. Thanks.
This is a good cleanup/deduplication; there are a few places where
similar cleanup can be done. Since this conflicted with one of my
more intrusive WIP branches, I figured it's better to clean up those
first, too.
Best,
Gábor
next prev parent reply other threads:[~2011-10-08 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 18:40 [PATCH 1/3] completion: unite --reuse-message and --reedit-message handling Teemu Matilainen
2011-10-06 18:40 ` [PATCH 2/3] completion: commit --fixup and --squash Teemu Matilainen
2011-10-06 18:40 ` [PATCH 3/3] completion: push --set-upstream Teemu Matilainen
2011-10-06 23:14 ` [PATCH 1/3] completion: unite --reuse-message and --reedit-message handling Junio C Hamano
2011-10-08 1:04 ` SZEDER Gábor [this message]
2011-10-08 1:06 ` [PATCH 1/2] completion: unite --reuse-message and --reedit-message for 'notes' SZEDER Gábor
2011-10-08 1:09 ` [PATCH 2/2] completion: unite --format and --pretty for 'log' and 'show' SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111008010432.GA11561@goldbirke \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=teemu.matilainen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).