From: Paul Mackerras <paulus@samba.org>
To: Marcus Karlsson <mk@acc.umu.se>
Cc: zbyszek@in.waw.pl, gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH v3] gitk: Teach gitk to respect log.showroot
Date: Sat, 8 Oct 2011 17:47:04 +1100 [thread overview]
Message-ID: <20111008064704.GA27056@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <20111004200813.GA16596@kennedy.acc.umu.se>
On Tue, Oct 04, 2011 at 10:08:13PM +0200, Marcus Karlsson wrote:
> Teach gitk to respect log.showroot.
Sounds reasonable, ...
> - set cmd [concat | git diff-tree -r $flags $ids]
> + set cmd [concat | git diff-tree -r]
> + if {$log_showroot eq true} {
> + set cmd [concat $cmd --root]
> + }
> + set cmd [concat $cmd $flags $ids]
but is there any reason not to do it like this?
if {$log_showroot} {
lappend flags --root
}
set cmd [concat | git diff-tree -r $flags $ids]
I.e., do you particularly want the --root before the other flags?
Paul.
next prev parent reply other threads:[~2011-10-08 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 20:08 [PATCH v3] gitk: Teach gitk to respect log.showroot Marcus Karlsson
2011-10-08 6:47 ` Paul Mackerras [this message]
2011-10-12 14:36 ` Marcus Karlsson
2012-03-18 22:53 ` Paul Mackerras
2012-03-19 11:04 ` Zbigniew Jędrzejewski-Szmek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111008064704.GA27056@bloggs.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mk@acc.umu.se \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).