Git development
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Michael Olson <mwolson@gnu.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-svn: Allow certain refs to be ignored
Date: Mon, 10 Oct 2011 15:58:38 -0700	[thread overview]
Message-ID: <20111010225838.GB3828@dcvr.yhbt.net> (raw)
In-Reply-To: <7vvcs0s7xa.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> Asking Eric to comment when he has time to do so.
> 
> I find these pattern matches that are not anchored on either side 
> somewhat disturbing (e.g. --ignore-refs=master would ignore master2)
> but ignore-paths codepath seems to follow the same pattern, so perhaps it
> is in line with what git-svn users want. I dunno.

As stated last year, I remember wanting globs instead of regexps, but
we already made the regexp mistake with ignore-paths, too :(

I don't think it's horrible with regexps, and if git-svn users find it
useful, it's fine by me.

> Michael Olson <mwolson@gnu.org> writes:
> > Re-sent by request of Piotr Krukowiecki.  This is against v1.7.4.1,
> > and I've been using it stably for a while.

Michael: can you please rebase against latest and resend?  Thanks.

  parent reply	other threads:[~2011-10-10 22:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07  0:41 [PATCH] git-svn: Allow certain refs to be ignored Michael Olson
2011-10-07 23:23 ` Junio C Hamano
2011-10-07 23:33   ` Michael Olson
2011-10-10 22:58   ` Eric Wong [this message]
2011-10-14  9:24     ` Piotr Krukowiecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111010225838.GB3828@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mwolson@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox