From: Jeff King <peff@peff.net>
To: "Carlos Martín Nieto" <cmn@elego.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Documentation: update [section.subsection] to reflect what git does
Date: Wed, 12 Oct 2011 14:27:42 -0400 [thread overview]
Message-ID: <20111012182742.GA14543@sigill.intra.peff.net> (raw)
In-Reply-To: <20111012174643.GA14336@sigill.intra.peff.net>
On Wed, Oct 12, 2011 at 01:46:43PM -0400, Jeff King wrote:
> On Wed, Oct 12, 2011 at 12:29:39PM -0400, Jeff King wrote:
>
> > The explanation matches what we do now, but it did end up a bit longer
> > than I had hoped. We could make it a lot shorter by:
> >
> > 1. Canonicalizing the section and key names that the caller gives to
> > git-config.
>
> Hmm. Scratch that. We seem to do this already in my tests. I'll look
> further and try to make a better documentation patch.
OK, I was all set to do a patch to git-config for this, but it seems the
code is already there. It's only the subsections which are the sticking
point, and those can't be canonicalized, because in most cases we need
to match them exactly.
In the process, I did some cleanup and added some new tests to t1300,
which I think are probably worth applying anyway.
[1/2]: t1300: put git invocations inside test function
[2/2]: t1300: test mixed-case variable retrieval
-Peff
next prev parent reply other threads:[~2011-10-12 18:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 15:52 [PATCH] Documentation: update [section.subsection] to reflect what git does Carlos Martín Nieto
2011-10-12 16:29 ` Jeff King
2011-10-12 17:46 ` Jeff King
2011-10-12 18:27 ` Jeff King [this message]
2011-10-12 18:29 ` [PATCH 1/2] t1300: put git invocations inside test function Jeff King
2011-10-19 6:41 ` Johannes Sixt
2011-10-19 7:04 ` Junio C Hamano
2011-10-19 7:37 ` [PATCH] t1300: attempting to remove a non-existent .git/config is not an error Johannes Sixt
2011-10-19 16:13 ` Jeff King
2011-10-12 18:30 ` [PATCH 2/2] t1300: test mixed-case variable retrieval Jeff King
2011-10-12 19:19 ` Junio C Hamano
2011-10-12 17:46 ` [PATCH] Documentation: update [section.subsection] to reflect what git does Junio C Hamano
2011-10-12 18:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012182742.GA14543@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).