From: Heiko Voigt <hvoigt@hvoigt.net>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] git-gui: new config to control staging of untracked files
Date: Mon, 17 Oct 2011 20:34:30 +0200 [thread overview]
Message-ID: <20111017183430.GA2540@sandbox-rc> (raw)
In-Reply-To: <03727ea04f20c953e7de3f84ab1724a8360ca2c4.1318620267.git.bert.wesarg@googlemail.com>
Hi,
what the series tries to achieve looks good to me. Just one comment.
On Fri, Oct 14, 2011 at 09:25:21PM +0200, Bert Wesarg wrote:
[...]
> diff --git a/lib/index.tcl b/lib/index.tcl
> index 014acf9..45094c2 100644
> --- a/lib/index.tcl
> +++ b/lib/index.tcl
> @@ -367,7 +367,19 @@ proc do_add_all {} {
> }
> }
> if {[llength $untracked_paths]} {
> - set reply [ask_popup [mc "Stage also untracked files?"]]
> + set reply 0
> + switch -- [get_config gui.stageuntracked] {
> + no {
> + set reply 0
> + }
[...]
Here I am wondering whether we have a similar mechanism in git gui like
in core git that makes yes,true,1 equivalents (and similar with other
values) ? If we don't I think the series is fine as it is otherwise it
probably makes sense to use that mechanism.
Cheers Heiko
next prev parent reply other threads:[~2011-10-17 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 19:25 [PATCH 1/3] git-gui: fix unintended line break in message string Bert Wesarg
2011-10-14 19:25 ` [PATCH 2/3] git-gui: use "untracked" for files which are not known to git Bert Wesarg
2011-10-14 19:25 ` [PATCH 3/3] git-gui: new config to control staging of untracked files Bert Wesarg
2011-10-17 18:34 ` Heiko Voigt [this message]
2011-10-17 18:47 ` Bert Wesarg
2011-10-17 19:27 ` Heiko Voigt
2011-10-17 22:51 ` Pat Thoyts
2011-10-18 6:34 ` Bert Wesarg
2011-10-18 8:24 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017183430.GA2540@sandbox-rc \
--to=hvoigt@hvoigt.net \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).