From: Heiko Voigt <hvoigt@hvoigt.net>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>, git@vger.kernel.org
Subject: Re: Re: [PATCH 3/3] git-gui: new config to control staging of untracked files
Date: Mon, 17 Oct 2011 21:27:07 +0200 [thread overview]
Message-ID: <20111017192706.GB3168@sandbox-rc> (raw)
In-Reply-To: <CAKPyHN3pKUSLTs8_5QMo5i+=3w7KXAHJjDOfQ1XYG92ZbQ1SeA@mail.gmail.com>
Hi,
On Mon, Oct 17, 2011 at 08:47:50PM +0200, Bert Wesarg wrote:
> On Mon, Oct 17, 2011 at 20:34, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > Here I am wondering whether we have a similar mechanism in git gui like
> > in core git that makes yes,true,1 equivalents (and similar with other
> > values) ?
>
> But it is not only yes,true,1 or no,false,0 its a tristate with the
> third state 'ask'. For booleans, there is such functionality in git
> gui. See is_config_true and is_config_false. Reusing these for this
> tristate wouldn't work. The current check here is indeed very strict
> and should be loosen by at least ignoring the case, surrounding
> spaces, and allow also true/false. But also note, that this variable
> can be set via the Options menu, so you can't mistype it.
Well if using git config you can ;-). I just wanted to ask whether we
may already have machinery which supports such tristate.
If we do not I think the current "strict" configuration is fine. In most
cases the user will use the gui itself to configure such behavior so
thats no big deal.
If someone needs that it can be added later on.
Thanks, Heiko
next prev parent reply other threads:[~2011-10-17 19:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 19:25 [PATCH 1/3] git-gui: fix unintended line break in message string Bert Wesarg
2011-10-14 19:25 ` [PATCH 2/3] git-gui: use "untracked" for files which are not known to git Bert Wesarg
2011-10-14 19:25 ` [PATCH 3/3] git-gui: new config to control staging of untracked files Bert Wesarg
2011-10-17 18:34 ` Heiko Voigt
2011-10-17 18:47 ` Bert Wesarg
2011-10-17 19:27 ` Heiko Voigt [this message]
2011-10-17 22:51 ` Pat Thoyts
2011-10-18 6:34 ` Bert Wesarg
2011-10-18 8:24 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017192706.GB3168@sandbox-rc \
--to=hvoigt@hvoigt.net \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).