From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Carlos Martín Nieto" <cmn@elego.de>,
git@vger.kernel.org
Subject: Re: [PATCH] t1300: attempting to remove a non-existent .git/config is not an error
Date: Wed, 19 Oct 2011 12:13:02 -0400 [thread overview]
Message-ID: <20111019161302.GA3157@sigill.intra.peff.net> (raw)
In-Reply-To: <4E9E7E22.7010905@viscovery.net>
On Wed, Oct 19, 2011 at 09:37:06AM +0200, Johannes Sixt wrote:
> From: Johannes Sixt <j6t@kdbg.org>
>
> Since some tests before test number 79 ("quoting") are skipped, .git/config
> does not exist and 'rm .git/config' fails. Fix this particular case.
>
> While at it, move other instance of 'rm .git/config' that occur in this
> file inside the test function to document that the test cases want to
> protect themselves from remnants of earlier tests.
Thanks, this fix looks good to me.
-Peff
next prev parent reply other threads:[~2011-10-19 16:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 15:52 [PATCH] Documentation: update [section.subsection] to reflect what git does Carlos Martín Nieto
2011-10-12 16:29 ` Jeff King
2011-10-12 17:46 ` Jeff King
2011-10-12 18:27 ` Jeff King
2011-10-12 18:29 ` [PATCH 1/2] t1300: put git invocations inside test function Jeff King
2011-10-19 6:41 ` Johannes Sixt
2011-10-19 7:04 ` Junio C Hamano
2011-10-19 7:37 ` [PATCH] t1300: attempting to remove a non-existent .git/config is not an error Johannes Sixt
2011-10-19 16:13 ` Jeff King [this message]
2011-10-12 18:30 ` [PATCH 2/2] t1300: test mixed-case variable retrieval Jeff King
2011-10-12 19:19 ` Junio C Hamano
2011-10-12 17:46 ` [PATCH] Documentation: update [section.subsection] to reflect what git does Junio C Hamano
2011-10-12 18:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019161302.GA3157@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).