From: Jonas Berlin <jonas.berlin@outerspace.dyndns.org>
To: Jonas Berlin <xkr47@outerspace.dyndns.org>
Cc: "SZEDER Gábor" <szeder@ira.uka.de>,
"Stefan Naewe" <stefan.naewe@gmail.com>,
spearce@spearce.org, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2] completion: fix issue with process substitution not working on Git for Windows
Date: Thu, 27 Oct 2011 13:40:43 +0300 [thread overview]
Message-ID: <20111027134043.56519ca4@outerspace.dyndns.org> (raw)
In-Reply-To: <20111027132754.1503b98b@outerspace.dyndns.org>
On Thu, 27 Oct 2011 13:27:54 +0300
Jonas Berlin <xkr47@outerspace.dyndns.org> wrote:
> On Thu, 27 Oct 2011 11:05:30 +0200
> SZEDER Gábor <szeder@ira.uka.de> wrote:
> > The $output variable is not declared as local and therefore it leaks
> > into the environment. But instead of declaring it local, why not
> > eliminate it altogether, and use the "$(git config ....)" command
> > substitution as here string?
>
> Wouldn't this work:
>
> git config -z --get-regexp '^(svn-remote\..*\.url|bash\.showupstream)$' 2>/dev/null | tr '\0\n' '\n ' | \
> while read key value; do
> ...
> done
Sorry, please disregard, I didn't notice it was already dismissed in v1 of the PATCH..
- xkr47
prev parent reply other threads:[~2011-10-27 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 18:01 [PATCH] completion: fix issue with process substitution not working on Git for Windows Stefan Naewe
2011-10-25 20:39 ` Johannes Sixt
2011-10-26 6:52 ` Stefan Näwe
2011-10-26 19:13 ` [PATCH v2] " Stefan Naewe
2011-10-26 20:02 ` Junio C Hamano
2011-10-26 21:07 ` Junio C Hamano
2011-10-27 6:26 ` Stefan Näwe
2011-10-27 9:05 ` SZEDER Gábor
2011-10-27 10:27 ` Jonas Berlin
2011-10-27 10:40 ` Jonas Berlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027134043.56519ca4@outerspace.dyndns.org \
--to=jonas.berlin@outerspace.dyndns.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=stefan.naewe@gmail.com \
--cc=szeder@ira.uka.de \
--cc=xkr47@outerspace.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).