From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] credential-cache--daemon.c: Don't leave stale socket on --exit
Date: Thu, 27 Oct 2011 10:42:08 -0700 [thread overview]
Message-ID: <20111027174208.GB1967@sigill.intra.peff.net> (raw)
In-Reply-To: <4EA9950A.9020208@ramsay1.demon.co.uk>
On Thu, Oct 27, 2011 at 06:29:46PM +0100, Ramsay Jones wrote:
> Jeff King wrote:
> > On Sat, Oct 22, 2011 at 06:24:51PM +0100, Ramsay Jones wrote:
> >
> >> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> >> ---
> >> credential-cache--daemon.c | 23 ++++++++++++-----------
> >> 1 files changed, 12 insertions(+), 11 deletions(-)
> >
> > Looks sane, and I'll probably squash it in. Alternatively, we could also
> > set a signal/exit handler to clean up our socket when we die. That would
> > also cover the error exit cases.
>
> I considered this, *very* briefly, but decided it wasn't worth the effort
> or complexity.
Actually, I think with the sigchain code, it would only end up as a few
lines. I'll probably take a look when I re-roll.
Thanks for your patches.
-Peff
prev parent reply other threads:[~2011-10-27 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-22 17:24 [PATCH 1/2] credential-cache--daemon.c: Don't leave stale socket on --exit Ramsay Jones
2011-10-22 19:17 ` Jeff King
2011-10-27 17:29 ` Ramsay Jones
2011-10-27 17:42 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027174208.GB1967@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).