From: Jeff King <peff@peff.net>
To: Andrew Eikum <aeikum@codeweavers.com>
Cc: git@vger.kernel.org
Subject: Re: imap-send badly handles commit bodies beginning with "From <"
Date: Fri, 28 Oct 2011 13:32:57 -0700 [thread overview]
Message-ID: <20111028203256.GA15082@sigill.intra.peff.net> (raw)
In-Reply-To: <20111028180044.GA3966@foghorn.codeweavers.com>
On Fri, Oct 28, 2011 at 01:00:44PM -0500, Andrew Eikum wrote:
> On the server side, it was split into two mails on either side of that
> commit message's From line with neither mail actually containing the
> From line. To fix it, I just changed it to "Copied from <url>:" :-P
>
> Ain't mbox grand?
Mbox does have this problem, but I think in this case it is a
particularly crappy implementation of mbox in imap-send. Look at
imap-send.c:split_msg; it just looks for "From ".
It should at least check for something that looks like a timestamp, like
git-mailsplit does. Maybe mailsplit's is_from_line should be factored
out so that it can be reused in imap-send.
Want to work on a patch?
-Peff
next prev parent reply other threads:[~2011-10-28 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 18:00 imap-send badly handles commit bodies beginning with "From <" Andrew Eikum
2011-10-28 20:32 ` Jeff King [this message]
2011-10-28 21:21 ` Andrew Eikum
2011-10-28 21:37 ` Jeff King
2011-10-30 9:01 ` Magnus Bäck
2011-11-01 15:38 ` Jeff King
2011-11-01 16:06 ` Michael Haggerty
2011-11-01 16:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028203256.GA15082@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=aeikum@codeweavers.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).