From: Jeff King <peff@peff.net>
To: Andrew Eikum <aeikum@codeweavers.com>
Cc: git@vger.kernel.org
Subject: Re: imap-send badly handles commit bodies beginning with "From <"
Date: Fri, 28 Oct 2011 14:37:04 -0700 [thread overview]
Message-ID: <20111028213703.GA1454@sigill.intra.peff.net> (raw)
In-Reply-To: <20111028212122.GB3966@foghorn.codeweavers.com>
On Fri, Oct 28, 2011 at 04:21:22PM -0500, Andrew Eikum wrote:
> Since we have a program called "mailsplit," wouldn't it make more
> sense to have imap-send use its implementation to split mail instead
> of sharing just the From line detection?
Potentially, yeah. I was thinking of just pulling over the from line
detection (which is the real black magic bit), but it looks like
imap-send's mbox handling could use some general attention (maybe it
would be possible to not read the entire mbox into memory, for example).
> I was hoping it'd be a quick matter of pulling mailsplit's
> implementation out of builtin and into the top level, but I see it's
> got some global variables that are tangled enough that I actually have
> to understand the code before I can pull it apart :)
>
> If no one beats me to it, I'll work on this next week. It's late on
> Friday and I'm moving house this weekend.
No rush. Let us know if you have questions.
> Quick question, since I'm not intimately familiar with Git's code: I
> was thinking of creating a new compilation unit at the top level,
> mailutils.{c,h}, and referencing it from both imap-send.c and
> builtin/splitmail.c. Does that seem like the right approach? Is there
> an existing compilation unit I should be placing splitmail's guts into
> instead?
Yes, I think a new file makes sense here. Make sure to update LIB_H and
LIB_OBJS in the Makefile.
-Peff
next prev parent reply other threads:[~2011-10-28 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 18:00 imap-send badly handles commit bodies beginning with "From <" Andrew Eikum
2011-10-28 20:32 ` Jeff King
2011-10-28 21:21 ` Andrew Eikum
2011-10-28 21:37 ` Jeff King [this message]
2011-10-30 9:01 ` Magnus Bäck
2011-11-01 15:38 ` Jeff King
2011-11-01 16:06 ` Michael Haggerty
2011-11-01 16:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028213703.GA1454@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=aeikum@codeweavers.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).