From: "Dmitry V. Levin" <ldv@altlinux.org>
To: git@vger.kernel.org
Subject: git rev-parse --since=1970-01-01 does not work reliably
Date: Mon, 31 Oct 2011 20:17:09 +0400 [thread overview]
Message-ID: <20111031161708.GA29924@altlinux.org> (raw)
Hi,
git rev-parse --since=1970-01-01 (and other git commands that take
date string arguments like --since) may fail when --since=1970-01-01 is
given. Whether it fails or not depends on current time and timezone data.
For example, "TZ=Europe/Paris git rev-parse --since=1970-01-01" fails two
hours a day (between 00:00 and 02:00 CET), and those who use more eastern
timezones are even less lucky. In artificial timezones like UTC-24 it
always fails:
$ TZ=UTC-24 git rev-parse --since=1970-01-01
--max-age=18446744073709523490
The problem is that several internal git functions implicitly convert
time_t to unsigned long, so when time_t gets negative, all date string
processing breaks.
--
ldv
next reply other threads:[~2011-10-31 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 16:17 Dmitry V. Levin [this message]
2011-10-31 23:13 ` git rev-parse --since=1970-01-01 does not work reliably Nguyen Thai Ngoc Duy
2011-11-01 12:44 ` Dmitry V. Levin
2011-11-03 12:36 ` Nguyen Thai Ngoc Duy
2011-11-03 23:37 ` Nguyen Thai Ngoc Duy
2011-11-04 0:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031161708.GA29924@altlinux.org \
--to=ldv@altlinux.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).