From: Jeff King <peff@peff.net>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: "Magnus Bäck" <magnus.back@sonyericsson.com>,
git@vger.kernel.org, "Andrew Eikum" <aeikum@codeweavers.com>
Subject: Re: imap-send badly handles commit bodies beginning with "From <"
Date: Tue, 1 Nov 2011 09:14:12 -0700 [thread overview]
Message-ID: <20111101161412.GA7796@sigill.intra.peff.net> (raw)
In-Reply-To: <4EB01918.8080604@alum.mit.edu>
On Tue, Nov 01, 2011 at 05:06:48PM +0100, Michael Haggerty wrote:
> On 11/01/2011 04:38 PM, Jeff King wrote:
> > Right. If you properly quote and unquote "From " lines, then mbox can be
> > unambiguous.
>
> That is not quite true. The RFC says only that lines matching "^From "
> should be quoted, not lines matching "^>From " (or, generally, "^>*From
> "). So the quoting is lossy; it is *not* possible to tell whether a
> line starting with ">From " should be unquoted (it could have been
> ">From " in the original).
That was what I meant by "properly". Note that the second link Magnus
mentioned (and which is referred to in the RFC in the paragraph
immediately following the discussion of "from" quoting) discusses this
explicitly.
The real issue with mbox is not that it can't be done well, but that you
have no clue which variant the writing end used. In practice, it works
OK because it's simple and those corner cases just don't come up much
(at least for a reasonably defensive reader).
-Peff
prev parent reply other threads:[~2011-11-01 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 18:00 imap-send badly handles commit bodies beginning with "From <" Andrew Eikum
2011-10-28 20:32 ` Jeff King
2011-10-28 21:21 ` Andrew Eikum
2011-10-28 21:37 ` Jeff King
2011-10-30 9:01 ` Magnus Bäck
2011-11-01 15:38 ` Jeff King
2011-11-01 16:06 ` Michael Haggerty
2011-11-01 16:14 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101161412.GA7796@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=aeikum@codeweavers.com \
--cc=git@vger.kernel.org \
--cc=magnus.back@sonyericsson.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).