From: Jeff King <peff@peff.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Erik Faye-Lund <kusmabite@gmail.com>,
git@vger.kernel.org, gitster@pobox.com, j6t@kdbg.org,
rene.scharfe@lsrfire.ath.cx
Subject: Re: [PATCH v4 3/3] upload-archive: use start_command instead of fork
Date: Tue, 15 Nov 2011 05:28:08 -0500 [thread overview]
Message-ID: <20111115102807.GA18649@sigill.intra.peff.net> (raw)
In-Reply-To: <201111151122.48378.trast@student.ethz.ch>
On Tue, Nov 15, 2011 at 11:22:48AM +0100, Thomas Rast wrote:
> > Remove the NOT_MINGW-prereq for t5000, as git-archive --remote
> > now works.
>
> I see valgrind failures bisecting to this commit, like so:
>
> ==19125== Syscall param execve(argv[i]) points to unaddressable byte(s)
> ==19125== at 0x5303CB7: execve (in /lib64/libc-2.11.3.so)
> ==19125== by 0x53045A5: execvpe (in /lib64/libc-2.11.3.so)
> ==19125== by 0x4B183C: execv_git_cmd (exec_cmd.c:137)
> ==19125== by 0x4F305E: start_command (run-command.c:277)
> ==19125== by 0x47F5C9: cmd_upload_archive (upload-archive.c:98)
> ==19125== by 0x4051F4: run_builtin (git.c:308)
> ==19125== by 0x40538F: handle_internal_command (git.c:466)
> ==19125== by 0x405556: main (git.c:553)
> ==19125== Address 0x7feffe7d0 is not stack'd, malloc'd or (recently) free'd
>
> when running 'make valgrind' in current master. Let me know if you
> need more information.
With which test, and on what OS? I couldn't replicate running
t5000 on Linux.
-Peff
next prev parent reply other threads:[~2011-11-15 10:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 16:02 [PATCH v4 0/3] port upload-archive to Windows Erik Faye-Lund
2011-10-24 16:02 ` [PATCH v4 1/3] mingw: move poll out of sys-folder Erik Faye-Lund
2011-10-24 16:02 ` [PATCH v4 2/3] compat/win32/poll.c: upgrade from upstream Erik Faye-Lund
2011-10-24 16:02 ` [PATCH v4 3/3] upload-archive: use start_command instead of fork Erik Faye-Lund
2011-10-24 22:39 ` Jeff King
2011-11-15 10:22 ` Thomas Rast
2011-11-15 10:28 ` Jeff King [this message]
2011-11-15 12:11 ` Thomas Rast
2011-11-15 17:37 ` Jeff King
2011-11-15 17:44 ` Erik Faye-Lund
2011-11-15 18:18 ` Jeff King
2011-11-15 18:59 ` Junio C Hamano
2011-11-15 19:18 ` Jeff King
2011-11-15 19:46 ` [PATCH 1/2] upload-archive: drop extra argument to prepare_argv Jeff King
2011-11-15 19:49 ` [PATCH] upload-archive: use argv_array for sent parameters Jeff King
2011-11-15 21:30 ` Jeff King
2011-11-15 18:53 ` [PATCH v4 3/3] upload-archive: use start_command instead of fork Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115102807.GA18649@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=kusmabite@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).